Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding license audit date as last 30 days #8427

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

YashviJain01
Copy link
Collaborator

@YashviJain01 YashviJain01 commented Apr 18, 2024

πŸ”© Description: What code changed, and why?

Changing the days of license audit data to be 30 days. Now it will send all the unique nodes for last 30 days.

⛓️ Related Resources

https://chefio.atlassian.net/browse/CHEF-11615

πŸ‘ Definition of Done

πŸ‘Ÿ How to Build and Test the Change

rebuild components/compliance-service/
rebuild components/config-mgmt-service/
rebuild components/license-control-service

βœ… Checklist

All PRs must tick these:

With occasional exceptions, all PRs from Progress employees must tick these:

  • Is the code clear? (complicated code or lots of comments--subdivide and use well-named methods, meaningful variable names, etc.)
  • Consistency checked? (user notifications, user prompts, visual patterns, code patterns, variable names)
  • Repeated code blocks eliminated? (adapt and reuse existing components, blocks, functions, etc.)
  • Spelling, grammar, typos checked? (at a minimum use make spell in any component directory)
  • Code well-formatted? (indents, line breaks, etc. improve rather than hinder readability)

All PRs from Progress employees should tick these if appropriate:

  • Tests added/updated? (all new code needs new tests)
  • Docs added/updated? (all customer-facing changes)

Please add a note next to any checkbox above if you are NOT ticking it.

πŸ“· Screenshots, if applicable

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Copy link

netlify bot commented Apr 18, 2024

πŸ‘· Deploy Preview for chef-automate processing.

Name Link
πŸ”¨ Latest commit f3753d8
πŸ” Latest deploy log https://app.netlify.com/sites/chef-automate/deploys/66448edd301b760008ff7b86

Yashvi Jain added 5 commits April 18, 2024 15:13
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>

SonarQube Quality Gate

Quality Gate failed

Failed condition 26.5% 26.5% Coverage on New Code (is less than 80%)
Failed condition 46.2% 46.15% Duplicated Lines (%) on New Code (is greater than 3%)

See analysis details on SonarQube

Signed-off-by: Yashvi Jain <yashvi.jain@progress.com>
@YashviJain01 YashviJain01 marked this pull request as ready for review May 14, 2024 10:29
Signed-off-by: SahithiMy <sahithi.mylangam@progress.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant