Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve Report API performance #9476

Merged
merged 25 commits into from
May 23, 2024
Merged

Conversation

pranavrajs
Copy link
Member

  • Re-write the methods for clarity
  • Remove the dependency on the ReportHelper class.
  • Remove n+1 queries in the average metric time series data.

@pranavrajs
Copy link
Member Author

Code Climate issue can be ignored as we will remove the reports_helper in the subsequent PRs.

@sojan-official sojan-official temporarily deployed to chatwoot-pr-9476 May 16, 2024 06:02 Inactive
@pranavrajs pranavrajs marked this pull request as ready for review May 21, 2024 20:48
Copy link
Member

@sojan-official sojan-official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • verified all reports are loading in local

@sojan-official sojan-official merged commit 87d92f7 into develop May 23, 2024
14 of 15 checks passed
@sojan-official sojan-official deleted the report-perf-improvements branch May 23, 2024 00:34
Copy link

sentry-io bot commented May 27, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ActiveRecord::QueryCanceled: PG::QueryCanceled: ERROR: canceling statement due to statement timeout (ActiveRecord::QueryCance... Api::V2::Accounts::ReportsController#index View Issue
  • ‼️ **NoMethodError: undefined method to_sym' for nil:NilClass (NoMethodError)** Api::V2::Accounts::ReportsController#summary` View Issue
  • ‼️ **NoMethodError: undefined method to_sym' for nil:NilClass (NoMethodError)** Api::V2::Accounts::ReportsController#index` View Issue
  • ‼️ Date::Error: invalid date (Date::Error) Api::V2::Accounts::ReportsController#index View Issue
  • ‼️ Date::Error: invalid date (Date::Error) Api::V2::Accounts::ReportsController#index View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants