Improve Mason error when git is missing #25069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
|
Do we not have a way of detecting that |
The best way in Chapel code I could come up with was running a loop over all directories in Another slightly cleaner alternative is to have |
benharsh
reviewed
May 20, 2024
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
benharsh
approved these changes
May 21, 2024
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
benharsh
approved these changes
May 21, 2024
jabraham17
added a commit
that referenced
this pull request
May 22, 2024
This PR expands on the work in #25069 to improve mason errors when dependencies (specifically git) are missing. This PR adds additional logic to account for portability issues exposed by nightly testing Testing - Tested the two tests added in #25069 pass on a Mac - Tested `start_test test/mason` passes on linux x86 - Tested `start_test test/mason` passes on the nightly test machine (a slightly different linux x86) [Reviewed by @benharsh]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the error thrown by Mason when git is missing. Prior to this PR, all that would be thrown was
"Internal mason error", which is not helpful.PR also includes a bonus typo fix in the docs for Subprocess
Checked that the test for this error message passes
[Reviewed by @benharsh]