Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C++ standard specified for protobuf build #25049

Merged
merged 2 commits into from
May 20, 2024

Conversation

riftEmber
Copy link
Member

@riftEmber riftEmber commented May 15, 2024

Recent versions of protobuf depend on abseil-cpp, and abseil requires at least C++14. However, we specify the use of C++11 in the compile flags for our protoc-gen-chpl target. Update it to C++17 since that's what Chapel in general requires.

d1a649a (#16817) asserts the -std argument is required for building on Mac, which holds up on my Mac with Clang 15; however, it works with -std=c++17 instead of 11.

[reviewer info placeholder]

Testing:

Signed-off-by: Anna Rift <anna.rift@hpe.com>
@riftEmber riftEmber changed the title Remove setting C++11 standard for protobuf build Update C++ standard specified for protobuf build May 15, 2024
Signed-off-by: Anna Rift <anna.rift@hpe.com>
@riftEmber riftEmber merged commit 0afff87 into chapel-lang:main May 20, 2024
7 checks passed
@riftEmber riftEmber deleted the protobuf-cpp-std branch May 20, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants