Update C++ standard specified for protobuf build #25049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of protobuf depend on abseil-cpp, and abseil requires at least C++14. However, we specify the use of C++11 in the compile flags for our
protoc-gen-chpl
target. Update it to C++17 since that's what Chapel in general requires.d1a649a
(#16817) asserts the-std
argument is required for building on Mac, which holds up on my Mac with Clang 15; however, it works with-std=c++17
instead of 11.[reviewer info placeholder]
Testing:
make protoc-gen-chpl
succeeds with a protobuf requiring abseil, on Mac and Linux