Deprecate chpl_comm_array_get and chpl_comm_array_put
#24833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should drop chpl_comm_array_get and chpl_comm_array_put primitives altogether. They differ from "non-array" versions only by accepting number of elements instead of number of bytes. I don't think it is a big help to its users, and it unnecessarily complicates the compiler code. Note that this "array"/"non-array" difference doesn't exist in the runtime. Signed-off-by: Shreyas Khandekar <60454060+ShreyasKhandekar@users.noreply.github.com>
Signed-off-by: Shreyas Khandekar <60454060+ShreyasKhandekar@users.noreply.github.com>
Signed-off-by: Shreyas Khandekar <60454060+ShreyasKhandekar@users.noreply.github.com>
Signed-off-by: Shreyas Khandekar <60454060+ShreyasKhandekar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion from https://github.com/Cray/chapel-private/issues/5493. This PR implements part (1) of the proposal there. Follow up PR's will implement the other points in the linked issue.
As part of this PR we have deprecated the
chpl_comm_array_getandchpl_comm_array_putprimitives and only want to usechpl_comm_getandchpl_comm_putgoing forward for our own needs.Users should not be using either of these, but we're deprecating instead of removing these out of an abundance of caution.