fix nightly script for parallel blog tests, remove hello flag #24826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: arezaii <ahmad.rezaii@hpe.com>
Signed-off-by: arezaii <ahmad.rezaii@hpe.com>
arezaii
force-pushed
the
fix-blog-paratest-args
branch
from
be1686e
to
964a00c
Compare
arezaii
changed the title
tzinsky
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem when the nightly
test-linux64-blog-onlyis ran when setup for paratest. Also adds better error output to differentiate betweenblogdirnot found andblogdirnot set.Previously the
blogonlytesting did not play well with paratest because it placed thetestdirsafter the paratest args instead of in theDIRFILE. This changes that by checking for a paratest file and then writing our test directories to it inblogonlymode, similar to howexamplestests do. In normalblogmode, the test dirs should be included by way of being located within thetestdirectory.While here, noticed that the
helloflag is an outlier in this script, and was not being used by any of our testing. After some discussion with @DanilaFe and the dev-ops subteam, we decided to remove this flag.