Unify MG transfer operators by using MGTransferMF #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lpsaavedra @blaisb May I ask you to try out this branch now and then. In deal.II, we in the process of merging
MGTransferMatrixFreeandMGTransferGlobalCoarsening. The new classMGTransferMFis essentially the oldMGTransferGlobalCoarseningwith some features added to support local smoothing. I am still trying to reduce the setup costs ofMGTransferMF. Once that is done the old content of the oldMGTransferMatrixFreecan be removed and will be replaced by the current content ofMGTransferMF. All tests inside of deal.II are passing withMGTransferMF, which is a good sign. But maybe there some features (e.g., special constraints) that are not tested. In the case that you should observe any kinds of differences, I would like to ask you to report this; since the intentions is that the behavior is identical to the current state and diverging behavior would be considered as an unintentional bug.