Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add author first names #3605

Open
wants to merge 3 commits into
base: qa
Choose a base branch
from
Open

Add author first names #3605

wants to merge 3 commits into from

Conversation

rdebrand
Copy link
Contributor

No description provided.

@rdebrand
Copy link
Contributor Author

Left the dots in there as there were double initials (e.g. J.J.), also left the et al. after the name.

@@ -98,13 +98,13 @@
"accelerator": "DESY-PETRA",
"authors": [
{
"name": "Hagermann"
"name": "Hagermann, J."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bibliographic standard is to leave the initial without the dots, i.e. "Hagermann, J" format. This will better compare to what CDS, INSPIRE etc repositories are doing, and will also play more nicely with facets here when the first name is fully known.

Can you please amend the names to leave out trailing dots everywhere?

@@ -929,7 +929,7 @@
"accelerator": "DESY-PETRA",
"authors": [
{
"name": "Allison et al."
"name": "Allison, John et al."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "et al" part in the name would not be correct. We should have only the full author name there so that the name is searchable uniquely across records regardless of collaborators.

For the "et al" parts, ideally we should expand them, e.g. note 18 shows the full list of authors, so the record here should ideally say:

    "authors": [
      {
        "name": "Allison, John"
      },
      {
        "name": "Dittmann, P"
      },
      {
        "name": "Elsen, E"
      },
      {
        "name": "O'Neill, L"
      },
      {
        "name": "Steffen, P"
      },
      {
        "name": "Yamada, S"
      },
    ]

Can you please expand all the four instances of "et al" correspondingly?

},
{
"name": "Pryce"
"name": "Pryce, J.J."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of two initials, we should use space and leave out the dots, e.g. "Pryce, J J".

Can you please amend this here and elsewhere for people having two initials?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants