-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src/test: add testcase file for low level sync io code paths #57576
base: main
Are you sure you want to change the base?
Conversation
backports like https://tracker.ceph.com/issues/64740 or https://tracker.ceph.com/issues/64739 which are intended for async io are not possible because older releases do not have that feature(feature is available only since squid), but that doesn't mean we cannot/shouldn't backport the patch #55457, the code that it fixes also impact the sync code path, we anyways have a tracker for this https://tracker.ceph.com/issues/63712 to add sync io (low level) code path test cases so let us have this test case merged into main and then this test case along with the source code from #55457 can be backported for the backport trackers mentioned above. |
Passes locally
|
once i'm done with my ongoing work, i'll push more test cases to this file for better sync io code coverage |
31d05d2
to
7b074f8
Compare
and test that providing null or invalid file handle returns an error as expected Fixes: https://tracker.ceph.com/issues/66156 Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
7b074f8
to
bc4bb1e
Compare
@dparmar18 As discussed, this needs to be backported along with the async test cases. For releases that don't have the async calls, we can backport the sync test cases. |
Please tag me on the PR when its ready for review. |
this is ready for review, for now this is the only sync io test case that needs to be merged |
This PR is under test in https://tracker.ceph.com/issues/66327. |
and test that providing null or invalid file handle returns an error as expected
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
x
between the brackets:[x]
. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e