Order types #22449

samgermain · 2024-05-09T15:44:52Z

% py blockchaincom cancelOrder 845046053386895      
Python v3.9.6
CCXT v4.3.18
blockchaincom.cancelOrder(845046053386895)
{'amount': None,
 'average': None,
 'clientOrderId': None,
 'cost': None,
 'datetime': None,
 'fee': None,
 'fees': [],
 'filled': None,
 'id': '845046053386895',
 'info': {},
 'lastTradeTimestamp': None,
 'lastUpdateTimestamp': None,
 'postOnly': None,
 'price': None,
 'reduceOnly': None,
 'remaining': None,
 'side': None,
 'status': None,
 'stopLossPrice': None,
 'stopPrice': None,
 'symbol': None,
 'takeProfitPrice': None,
 'timeInForce': None,
 'timestamp': None,
 'trades': [],
 'triggerPrice': None,
 'type': None}

% py blockchaincom cancelAllOrders ADA/USD
Python v3.9.6
CCXT v4.3.18
blockchaincom.cancelAllOrders(ADA/USD)
[]

carlosmiei · 2024-05-10T16:49:19Z

ts/src/lykke.ts

@@ -875,7 +875,7 @@ export default class lykke extends Exchange {
        }, market);
    }

-    async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
+    async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {


cancelOrder returns the raw response here

return await this.privateDe ...

carlosmiei · 2024-05-10T16:49:56Z

ts/src/whitebit.ts

@@ -1354,7 +1354,7 @@ export default class whitebit extends Exchange {
        return this.parseOrder (response);
    }

-    async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
+    async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {


same here, returns unparsed response

carlosmiei · 2024-05-10T16:50:14Z

ts/src/timex.ts

@@ -876,7 +876,7 @@ export default class timex extends Exchange {
        return this.parseOrder (order, market);
    }

-    async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
+    async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {


carlosmiei · 2024-05-10T16:50:33Z

ts/src/zaif.ts

@@ -477,7 +477,7 @@ export default class zaif extends Exchange {
        }, market);
    }

-    async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
+    async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {


carlosmiei · 2024-05-10T16:50:44Z

ts/src/zonda.ts

@@ -1476,7 +1476,7 @@ export default class zonda extends Exchange {
        });
    }

-    async cancelOrder (id: string, symbol: Str = undefined, params = {}) {
+    async cancelOrder (id: string, symbol: Str = undefined, params = {}): Promise<Order> {


carlosmiei · 2024-05-10T16:51:52Z

@samgermain We have a lot of methods that besides the type need to be adjusted to return the proper structure, many of them just return the raw response from the exchange

samgermain · 2024-05-10T23:37:26Z

@samgermain We have a lot of methods that besides the type need to be adjusted to return the proper structure, many of them just return the raw response from the exchange

yeah I'm working on it, it's quite a few changes

samgermain added 2 commits May 9, 2024 11:14

chore: order types

3df5a26

transpile Order as parameter type

5c317a5

samgermain added the enhancement label May 9, 2024

import Order type into exchange.py

e6cde02

carlosmiei self-assigned this May 10, 2024

carlosmiei reviewed May 10, 2024

View reviewed changes

cancelOrder modify response to return order structure

d1d9ab2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Order types #22449

Order types #22449

samgermain commented May 9, 2024 •

edited

carlosmiei May 10, 2024

carlosmiei May 10, 2024

carlosmiei May 10, 2024

carlosmiei May 10, 2024

carlosmiei May 10, 2024

carlosmiei commented May 10, 2024

samgermain commented May 10, 2024

Order types #22449

Are you sure you want to change the base?

Order types #22449

Conversation

samgermain commented May 9, 2024 • edited

carlosmiei May 10, 2024

Choose a reason for hiding this comment

carlosmiei May 10, 2024

Choose a reason for hiding this comment

carlosmiei May 10, 2024

Choose a reason for hiding this comment

carlosmiei May 10, 2024

Choose a reason for hiding this comment

carlosmiei May 10, 2024

Choose a reason for hiding this comment

carlosmiei commented May 10, 2024

samgermain commented May 10, 2024

samgermain commented May 9, 2024 •

edited