Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poloniex precision #22375

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

samgermain
Copy link
Member

@samgermain samgermain commented May 3, 2024

  • was receiving this previously ccxt.base.errors.ExchangeError: poloniex error: "Amount less than minAmount"
% py poloniex createOrder ADA/USDT market buy 3 0.45351  
Python v3.9.6
CCXT v4.3.14
poloniex.createOrder(ADA/USDT,market,buy,3,0.45351)
{'amount': None,
 'average': None,
 'clientOrderId': None,
 'cost': None,
 'datetime': None,
 'fee': None,
 'fees': [],
 'filled': None,
 'id': '309332062333095936',
 'info': {'clientOrderId': '', 'id': '309332062333095936', 'type': 'buy'},
 'lastTradeTimestamp': None,
 'lastUpdateTimestamp': None,
 'postOnly': None,
 'price': None,
 'reduceOnly': None,
 'remaining': None,
 'side': None,
 'status': None,
 'stopLossPrice': None,
 'stopPrice': None,
 'symbol': 'ADA/USDT',
 'takeProfitPrice': None,
 'timeInForce': None,
 'timestamp': None,
 'trades': [],
 'triggerPrice': None,
 'type': 'buy'}
% py bingx createOrder SOL/USDT market buy 0.04 138.37
Python v3.9.6
CCXT v4.3.14
bingx.createOrder(SOL/USDT,market,buy,0.04,138.37)
{'amount': 0.0399,
'average': None,
'clientOrderId': None,
'cost': 5.52216,
'datetime': '2024-05-03T06:40:40.890Z',
'fee': {'cost': None, 'currency': 'SOL'},
'fees': [{'cost': None, 'currency': 'SOL'}],
'filled': 0.0399,
'id': '1786284725959032832',
'info': {'clientOrderID': '',
         'cummulativeQuoteQty': '5.52269467931645',
         'executedQty': '0.0399',
         'orderId': '1786284725959032832',
         'origQty': '0',
         'price': '138.4',
         'side': 'BUY',
         'status': 'FILLED',
         'stopPrice': '0',
         'symbol': 'SOL-USDT',
         'transactTime': '1714718440890',
         'type': 'MARKET'},
'lastTradeTimestamp': None,
'lastUpdateTimestamp': None,
'postOnly': None,
'price': 138.4,
'reduceOnly': None,
'remaining': 0.0,
'side': 'buy',
'status': 'closed',
'stopLossPrice': None,
'stopPrice': 0.0,
'symbol': 'SOL/USDT',
'takeProfitPrice': None,
'timeInForce': 'IOC',
'timestamp': 1714718440890,
'trades': [],
'triggerPrice': 0.0,
'type': 'market'}

@samgermain samgermain added the bug label May 3, 2024
@samgermain samgermain marked this pull request as ready for review May 3, 2024 06:41
@carlosmiei
Copy link
Collaborator

@samgermain first we have to check the build, second since we're touching the precision I would expect some static tests with really weird prices/amount (like price 55000.24324234324 and amount 0.00142343243243)to assert the precision is properly set
image

@carlosmiei carlosmiei self-assigned this May 3, 2024
@samgermain
Copy link
Member Author

@samgermain first we have to check the build, second since we're touching the precision I would expect some static tests with really weird prices/amount (like price 55000.24324234324 and amount 0.00142343243243)to assert the precision is properly set image

The build would have been working locally, or else I wouldn't have been able to python test it

@carlosmiei
Copy link
Collaborator

@samgermain Doing some standalone tests is different from running the static tests, can you run them locally? they're clearly broken (it might be related to the stored static markets or something else, we need to check it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants