Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main.py #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

badr-elmazaz
Copy link

made it more pythonic

made it more pythonic
@carlospolop
Copy link
Owner

Hi @badr-elmazaz, does this work? removing all the warriors doesn't look like it will

@badr-elmazaz
Copy link
Author

badr-elmazaz commented Feb 9, 2024

Hi @carlospolop sorry, I had some notification issues that now I have solved, I just checked your reply. Actually it does not work. My real solution is to use a factory pattern here instead of using an elif structure, what do you think about it? It will be more robust and less timeconsuming when we will add new class. Let me know what you think about it, in this way I can contribuite with this idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants