SemIR fidelity when representing rewrite semantics #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerc
added
proposal
chandlerc
force-pushed
the
semir-rewrite-fidelity
branch
2 times, most recently
from
94a605c
to
96f3fcb
Compare
github-actions
bot
added
proposal rfc
jonmeow
reviewed
Mar 29, 2024
josh11b
reviewed
Mar 29, 2024
chandlerc
force-pushed
the
semir-rewrite-fidelity
branch
from
96f3fcb
to
ac5ac31
Compare
josh11b
reviewed
Mar 30, 2024
jonmeow
reviewed
Apr 1, 2024
chandlerc
force-pushed
the
semir-rewrite-fidelity
branch
from
51e359d
to
3de52f7
Compare
|
(the brief diff issues should be fixed now, sorry for that) |
chandlerc
force-pushed
the
semir-rewrite-fidelity
branch
2 times, most recently
from
e588bd6
to
3809e49
Compare
zygoloid
reviewed
Apr 24, 2024
chandlerc
commented
May 2, 2024
The toolchain's [Semantic IR][semir] should start off modeling the full,
complex, and rich library-based and generic extension point semantics of Carbon
without eliding any layers or rewrites for compile time efficiency. We shouldn't
front-load elision or optimization when implementing the designs.
Once we have a full-fidelity implementation, we should work to build an
efficient elision, short-circuit, or common case simplification into the design
itself sufficient to make the SemIR model efficient. Only if we cannot find a
reasonable approach for that should we diverge the SemIR model to optimize its
efficiency, and we should preserve full fidelity in an optional mode.
[semir]:
https://docs.google.com/document/d/1RRYMm42osyqhI2LyjrjockYCutQ5dOf8Abu50kTrkX0/edit?resourcekey=0-kHyqOESbOHmzZphUbtLrTw#heading=h.503m6lfcnmui
Co-authored-by: josh11b <15258583+josh11b@users.noreply.github.com>
chandlerc
force-pushed
the
semir-rewrite-fidelity
branch
from
8262d9c
to
c5538de
Compare
|
(Fixed weird mis-merge, sorry about that) |
chandlerc
commented
May 17, 2024
|
Ping? It's been a while since update... |
zygoloid
approved these changes
May 23, 2024
Co-authored-by: Richard Smith <richard@metafoo.co.uk>
Co-authored-by: Carbon Infra Bot <carbon-external-infra@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The toolchain's Semantic IR should start off modeling the full,
complex, and rich library-based and generic extension point semantics of Carbon
without eliding any layers or rewrites for compile time efficiency. We shouldn't
front-load elision or optimization when implementing the designs.
Once we have a full-fidelity implementation, we should work to build an
efficient elision, short-circuit, or common case simplification into the design
itself sufficient to make the SemIR model efficient. Only if we cannot find a
reasonable approach for that should we diverge the SemIR model to optimize its
efficiency, and we should preserve full fidelity in an optional mode.