Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AArch64 compatibility header #2321

Merged
merged 6 commits into from
May 31, 2024
Merged

AArch64 compatibility header #2321

merged 6 commits into from
May 31, 2024
+4,833 −15

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Apr 11, 2024 •
edited

Your checklist for this pull request

  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Based on: #2296

Adds an additional compatibility option for projects which want to use the ARM64 naming scheme.

Todo

  • Generate this header with auto-sync scripts.
  • Add docs about it in the release notes.

This adds a compatibility header which defines every public AArch64 identifier again with the ARM64 prefix.

Test plan

  • Add example build test.

Closing issues

None

@Rot127 Rot127 added the AArch64 Arch label Apr 11, 2024
@Rot127 Rot127 added this to the v6 milestone Apr 11, 2024
@github-actions github-actions bot added CS-core-files auto-sync and removed AArch64 Arch labels Apr 11, 2024
@github-actions github-actions bot added CS-core-files auto-sync and removed CS-core-files auto-sync labels Apr 20, 2024
@Rot127 Rot127 force-pushed the aarch64-compatibility branch 4 times, most recently from 11619ed to 6af06c4 Compare April 20, 2024 11:54
@Rot127 Rot127 marked this pull request as ready for review April 20, 2024 12:17
@Rot127 Rot127 force-pushed the aarch64-compatibility branch 2 times, most recently from cb7c5f9 to d6e8f01 Compare April 20, 2024 12:23
XVilka
XVilka suggested changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the documentation about release changes updated then too?

@Rot127
Copy link
Collaborator Author

Rot127 commented Apr 20, 2024

wdym? The v6 release notes are updated as well. See d6e8f01

XVilka
XVilka approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed that change. LGTM then.

@github-actions github-actions bot removed the auto-sync-files auto-sync label Apr 22, 2024
@XVilka
Copy link
Contributor

XVilka commented May 11, 2024

@kabeor @aquynh so, what was decided on this one?

@Rot127 Rot127 mentioned this pull request May 24, 2024
Draft
@XVilka
Copy link
Contributor

XVilka commented May 26, 2024

@kabeor @aquynh could you please look at this one? It's very important as was discussed before.

@Rot127 Rot127 mentioned this pull request May 29, 2024
Open
kabeor
kabeor approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@kabeor kabeor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merged!

@kabeor kabeor merged commit 1a6921f into capstone-engine:next May 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka approved these changes

@kabeor kabeor kabeor approved these changes

Assignees
No one assigned
Labels
CS-core-files auto-sync Documentation
Projects
Capstone V6 Plan
Status: Done
Milestone
v6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rot127 @XVilka @kabeor