-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump getdaft from 0.2.19 to 0.2.24 #223
Conversation
I have tried to bump the version of For example, the current implementation of the def has_min(self, rule: Rule, dataframe: daft.DataFrame) -> Union[bool, int]:
perdicate = daft.col(rule.column).min()
return dataframe.select(perdicate).to_pandas().iloc[0, 0] == rule.value It will raise this error:
There are some internal changes in Daft package that might cause this, there are more information here. SuggestionThis method (and others) should be update like this: def has_min(self, rule: Rule, dataframe: daft.DataFrame) -> Union[bool, int]:
col = daft.col(rule.column)
return dataframe.select(col).min(col).to_pandas().iloc[0, 0] == rule.value |
@canimus based on the information provided by @kevinzwang, in here; I need to modify the methods in |
Bumps [getdaft](https://github.com/Eventual-Inc/Daft) from 0.2.19 to 0.2.24. - [Release notes](https://github.com/Eventual-Inc/Daft/releases) - [Commits](Eventual-Inc/Daft@v0.2.19...v0.2.24) --- updated-dependencies: - dependency-name: getdaft dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
455a604
to
9079978
Compare
Looks like getdaft is up-to-date now, so this is no longer needed. |
Bumps getdaft from 0.2.19 to 0.2.24.
Release notes
Sourced from getdaft's releases.
... (truncated)
Commits
62f9dd6
[FEAT] Allow returning of pyarrow arrays from UDFs (#2252)f1d6570
[CHORE] Drop Python 3.7 (#2250)3b1a5ca
[BUG] Fix tab completion on expression namespaced accessors (#2251)0541774
[CHORE] Improve timestamp repr (#2245)b61461f
[PERF] Adaptive Query Execution (#2176)89e3916
[FEAT] Add left, right, and outer joins (#2166)e47b48a
[CHORE] Allow multiple group_bys for pivot (#2242)252721e
[CHORE] Skip demo notebook (#2248)d035454
[FEAT] Add rpad and lpad expressions (#2157)3e9dcd4
[BUG] route abfss to AzureBlob (#2244)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)