-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add console auth vars #1782
base: main
Are you sure you want to change the base?
Conversation
bd1bfd0
to
6b394ff
Compare
@aabouzaid Thanks for fixing the PR! The introduced vars are needed for a feature for console self-managed: byo oidc. Would be great if you can review it. |
@@ -63,3 +63,18 @@ Get the image pull secrets. | |||
"context" $ | |||
) -}} | |||
{{- end }} | |||
|
|||
{{/* | |||
[console] Define variables related to authentication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to wrap the plain vars in the named templates?
If not, let's use them directly in the configmap.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aabouzaid Not sure what you mean ;) I just need the vars in the configmap.
If you could make the adjustments I'd be more than happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@urbanisierung my question about doing this:
clientId: {{ include "console.authClientId" . | quote }}
not this:
clientId: {{- .Values.global.identity.auth.console.clientId | quote -}}
the point here, it's working like a var, but used in 1 place only.
do you have any plans to use it in different places or extend the logic?
Which problem does the PR fix?
What's in this PR?
Running
make go.update-golden-only
leads to the following error:Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only
.After opening the PR: