-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add volumeClaimTemplates label selector in zeebe statefulSet #1773
base: main
Are you sure you want to change the base?
Conversation
@@ -251,8 +251,17 @@ spec: | |||
spec: | |||
accessModes: {{ .Values.zeebe.pvcAccessModes }} | |||
{{- if .Values.zeebe.pvcStorageClassName }} | |||
{{- if (eq "-" .Values.zeebe.pvcStorageClassName) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to make special handling here, using null
as a value should have the same effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was added to follow bitnami standard. But if you want it removed I can change it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need some handling here else the default storage class is used, which is not the desired outcome in cases where one wants to use pre provisioned PVs, hence not use storage classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which problem does the PR fix?
This PR add possibility to use pre-provisioned PVs for zeebe, by doing the following:
What's in this PR?
.Values.zeebe.pvcStorageClassName
is now checked if equal to"-"
(following the standard in the bitnami helm charts)". If so: provide an empty string to theStorageClassName
in order to prevent the kubernetes API from using the default storageClass (practically disabling storageClass usage). In earlier versions og this helm chart, whenever setting.Values.zeebe.pvcStorageClassName
to""
explicitly, helm interpret this asnil
and hence the default storage class is used (if any)..Values.zeebe.pvcSelector
, when provided, will provide the possibility to bind PVCs and PVs based on labels. https://kubernetes.io/docs/concepts/storage/persistent-volumes/#selectorExample:
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only
.After opening the PR: