fix: Database password secret required even if webModeler.restapi.externalDatabase.password is blank #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drodriguez-305
added
the
support
drodriguez-305
force-pushed
the
inc-support-21863-db-password-helm-chart
branch
from
eb34bad
to
6447c87
Compare
aabouzaid
reviewed
May 27, 2024
| @@ -34,11 +34,13 @@ spec: | |||
| env: | |||
| - name: JAVA_OPTIONS | |||
| value: "-XX:MaxRAMPercentage=80.0" | |||
| {{- if or (not .Values.webModeler.restapi.externalDatabase.enabled) .Values.webModeler.restapi.externalDatabase.password }} | |||
There was a problem hiding this comment.
Let's add a unit test for this, please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem does the PR fix?
Related to https://jira.camunda.com/browse/SUPPORT-21863
When configuring WebModeler.RestAPI to Postgres using IAM Role Base Authentication, it should not require environment variable SPRING_DATASOURCE_PASSWORD and its corresponding secret to be set
What's in this PR?
It enables configuration of WebModeler.RestAPI to Postgres using IAM Role Base Authentication without requiring password secret defined and environment variable from rendering into the Kubernetes resource
Checklist
Please make sure to follow our Contributing Guide.
Before opening the PR:
make go.update-golden-only.After opening the PR: