Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add renovate config requiredStatusChecks #1751

Closed
wants to merge 1 commit into from

Conversation

drodriguez-305
Copy link
Contributor

Which problem does the PR fix?

Renovate pushed dependency changes even though the unit test failed.

What's in this PR?

To prevent this happening in the future we have added requiredStatusChecks to the renovate config.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@drodriguez-305 drodriguez-305 added this to the 8.6 Release Cycle milestone May 7, 2024
@drodriguez-305 drodriguez-305 self-assigned this May 7, 2024
@drodriguez-305 drodriguez-305 marked this pull request as draft May 8, 2024 02:00
Copy link
Member

@aabouzaid aabouzaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config requiredStatusChecks doesn't exist anymore in renovatebot config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants