Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web-modeler): remove unnecessary environment variables #1726

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wollefitz
Copy link
Member

@wollefitz wollefitz commented May 2, 2024

Which problem does the PR fix?

Removes unnecessary environment variables after switching the underlying websockets library, see https://github.com/camunda/cawemo-laravel-websockets/issues/375

Merge only after Web Modeler's 8.6.0-alpha1 release.

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants