New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

217 split operate #1524

Draft

jessesimpson36 wants to merge 71 commits into main from 217-split-operate

+6,265 −3,286

Contributor

jessesimpson36 commented Apr 3, 2024 •

edited

Which problem does the PR fix?

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

In the repo's root dir, run make go.update-golden-only.
There is no other open pull request for the same update/change.
Tests for charts are added (if needed).
In-repo documentation are updated (if needed).

After opening the PR:

Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
Did all checks/tests pass in the PR?

aabouzaid and others added 30 commits

March 16, 2024 00:19


          refactor!: move identity and its dependencies to top-level (#1448)

c3541c8

BREAKING CHANGE: Following the unified naming convention, the following values file keys have been changed 1-to-1:
- "identity.keycloak" became "identityKeycloak"
- "identity.postgresql" became "identityPostgresql"

Check the migration steps for more details:
https://docs.camunda.io/docs/next/self-managed/platform-deployment/helm-kubernetes/upgrade/#version-update-instructions

Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>


          refactor!: rename web-modeler postgres key to webModelerPostgresql (#…

1f2304f

…1451)

BREAKING CHANGE: Following the unified naming convention, the following values file keys have been changed 1-to-1:
- "postgresql" became "webModelerPostgresql"

Check the migration steps for more details:
https://docs.camunda.io/docs/next/self-managed/platform-deployment/helm-kubernetes/upgrade/#version-update-instructions

Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>


          chore: tidy up openshift/values.yaml

9ef80e4


          refactor!: rename zeebe-gateway key from to zeebeGateway (#1459)

fbeddeb

BREAKING CHANGE: Following the unified naming convention, the following values file keys have been changed 1-to-1:
- "zeebe-gateway" became "zeebeGateway"

Check the migration steps for more details:
https://docs.camunda.io/docs/next/self-managed/platform-deployment/helm-kubernetes/upgrade/#version-update-instructions

Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>


          chore: tidy up values keys for in the integration tests (#1460)

a38305f

Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>


          chore(deps): update redhat-actions/oc-login digest to 5eb45e8 (#1461)

934e6e7

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update camunda/console docker tag to v8.4.55 (#1462)

d642373

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update registry.camunda.cloud/console/console-sm docker …

b45e29c

…tag to v8.4.55 (#1463)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update github/codeql-action action to v3.24.8 (#1465)

69db80c

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore: update VERSION-MATRIX.md

d4efccd


          chore(deps): update github/codeql-action digest to 423a04b (#1466)

205b6a7

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update github/codeql-action digest to 1aae1e7 (#1467)

41b3986

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          fix(deps): update module github.com/gruntwork-io/terratest to v0.46.12 (

262f6ed

#1468)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update github/codeql-action digest to 294b6df (#1469)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update camunda/console docker tag to v8.4.57 (#1470)

eb9dba4

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update registry.camunda.cloud/console/console-sm docker …

938da1d

…tag to v8.4.57 (#1471)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update actions/cache digest to 0c45773 (#1472)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update actions/add-to-project action to v0.6.1 (#1473)

35e1f89

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore: generate reame

1e544d1


          refactor: upgrade elasticsearch from 8.9 to 8.12 (#1474)

70c85d4


          fix(deps): update module github.com/gruntwork-io/terratest to v0.46.13 (

008900a

#1477)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update github/codeql-action digest to 964f5e7 (#1478)

45e956a

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update github/codeql-action digest to 09d4101 (#1479)

1acc845

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          feat!: add zeebe gateway REST API (#1278)

a52a754

BREAKING CHANGE: zeebeGateway.ingress has been changed to zeebeGateway.ingress.rest and zeebeGateway.ingress.grpc

Check the migration steps for more details:
https://docs.camunda.io/docs/self-managed/platform-deployment/helm-kubernetes/upgrade/#version-update-instructions

Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>
Co-authored-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>


          fix: remove extra char in IDENTITY_URL (#1480)

351bb3d

Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>


          fix(follow-up): remove extra char in IDENTITY_URL (#1481)

3e019b9


          chore(deps): update github/codeql-action digest to 3d81734 (#1482)

2c127fb

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update camunda/console docker tag to v8.4.58 (#1483)

d82c937

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update github/codeql-action action to v3.24.9 (#1485)

9a19b72

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore: fail if refactored keys are not updated (#1486)

78ceced

Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>

maryarm and others added 26 commits

March 27, 2024 06:52


          refactor: upgrade keycloak from v22 to v23 (#1229)

81000d3

Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>


          fix: defining resources and limits for optimize migration container (#…

03088e0

…1487)

* Add resource and limits to optimize migration container


          chore(deps): update github/codeql-action digest to 84ba7fb (#1507)

72db699

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          feat(follow-up): Enable Identity for the Zeebe REST API (#1501)

fc10ecc

Co-authored-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>


          chore(deps): update actions/add-to-project action to v1 (#1506)

e93c5f3

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update actions/checkout digest to b4ffde6 (#1434)

730658d

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore: add global.identity.auth.console docs

08555e5


          feat: support customizing ingress pathType (#1509)


          chore: update README.md (#1510)

3eac83f


          feat: external elasticsearch (#1356)

c4e4f9c

* changes for es and os with constraints


          chore(deps): update helm release keycloak to v19.4.0 (#1515)

60bc3d6

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update helm release keycloak to v19.4.1 (#1516)

b74f9d2

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          docs: multiregion architecture docs (#1514)

6c769c3

* multiregion architecture docs


          chore(deps): update github/codeql-action digest to 99c9897 (#1517)

67a2e42

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update camunda/console docker tag to v8.5.0 (#1518)

5ce2324

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore(deps): update registry.camunda.cloud/console/console-sm docker …

a51fed4

…tag to v8.5.0 (#1519)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          chore: update identity postgresql error message

b89f906


          chore: update golden files

1bf254d


          refactor: adding zeebe rest config for tasklist (#1494)

b74fc20

Co-authored-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>


          feat(follow-up): enable zeebe contextPath for management port (#1508)

636e83f

Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>


          feat: override application config (#1297)

b6f150a

* feat: optimize app-style configuration

* fix: lowercased volume name

* fix: log4j2 configuration needs to be lowercase

* test: adds test for configuration option

* fix: corrected logback file path

* test: adds log4j2 config override test

* chore: Update README.md using readme-generator-for-helm

* test: adds test to include volume

* fix: referenced application.yaml when it should be environment-config.yaml for optimize

* chore: Update README.md using readme-generator-for-helm

* feat: override operate config

* style: reformatted some spaces that should've  been tabs

* test: added tests for operate configuration injection

* chore: Update README.md using readme-generator-for-helm

* wip: beginning next component

* feat: added tasklist configuration passthrough

* fix: fixed issue with log4j2 volumeMount in tasklist

* test: adds configuration tests to tasklist

* chore: Update README.md using readme-generator-for-helm

* feat: zeebe broker configuration passthrough implemented

* chore: Update README.md using readme-generator-for-helm

* feat: zeebe gateway application passthrough implemented

* fix: changes log4j2Configuration to extraConfiguration

* fix: fixed indentation errors from previous commit

* docs: update readme

* feat: first draft of app passthrough in web-modeler

* feat: first draft of connectors config passthrough

* feat: first draft of identity app passthrough

* fix: forgot configmap in last commit

* fix: remove env vars if configuration is set

* fix: adjust gateway to rely on configmap instead of env vars

* fix: move zeebe statefulset env vars to configmap

* fix: operate env vars moved to configmap

* fix: separate tasklist env vars to configmap. make sure to check on USER_RESTRICTIONS_ENABLED

* refactor: restapi env vars moved to configmap

* refactor: webapp env vars moved to configmap

* refactor: connectors env vars moved to configmap

* refactor: optimize env vars moved to configmap

* missed a file

* refactor: moving identity env vars to configmap

* fix: mount configuration volume always

* fix: identity client id not set

* fix: hopefully fixes client-id equality check in identity

* other attempted fix that didn't quite work out

* Revert identity env-var to configmap transfer

This reverts commit 8440939.

Revert "fix: hopefully fixes client-id equality check in identity"

This reverts commit d70d5ea.

Revert "fix: identity client id not set"

This reverts commit b1cc056.

Revert "fix: mount configuration volume always"

This reverts commit 8db5a0d.

Revert "refactor: moving identity env vars to configmap"

This reverts commit 897909e.

* fix: web-modeler always mounts configuration

* fix: wrong conditional location 🤦

* fix: misplaced conditional again... maybe I need a break.

* fix: apparently modeler webapp only reads toml config files

* fix: spring active profile is not configurable through environment-config.yaml

* fix: connectors was missing the filename in configmap

* wip

* Revert "Revert identity env-var to configmap transfer"

This reverts commit 896d50f.

* fix: only supply identity client-id + client-secret if both are provided

* fix: there actually isn't a need to set keycloak.environment.clients[]

* fix: optimize now runs using the configmap

Still need to look into why CAMUNDA_IDENTITY_CLIENT_ID is no longer being listened to.

* fix: optimize initContainers now uses mounted config

* fix: updating tests from env var to configmap

* test: reworked web-modeler tests that fail due to environment variables getting moved

* test: moved over more tests to configmaps

* test: moves over more tests of env vars to configmap and fixed a couple bugs

* chore: update golden

* fix: fixed bug where url wouldn't be set in certain modes

* fix: switch back to CAMUNDA_OPTIMIZE_IDENTITY_CLIENT_SECRET

* chore: update golden

* fix: accidently applied application-ccsm.yaml only to initContainer

* test: fixed test accidently finding wrong volumeMount

* chore: update golden

* refactor: moved identity multitenancy env vars to configmap

* refactor: rename configmap_spring to configmap

* fix: improper reference to old configmap name

* fix: fixed issue with identity not being able to authenticate

* external es and os changes (#1511)

* changes for adding support for external es and os

* fix: adds configmap checksums to app configmaps

* update golden files

* fix extra zeebe key

* add zeebeGateway.contextPath for mangement

Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>

* fix: add configuration to configuration configmaps

---------

Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Hamza Masood <47217263+hamza-m-masood@users.noreply.github.com>
Co-authored-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>


          ci: deleted gh environment instead just deactivate it (#1523)

5be6ddf

Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>


          feat: first draft of operate split

36ce60e


          fix: checksums in split out operate

0bfc17a


          fix: webapp service type mapping

a11b5ff


          fix: zeebePort was referenced for some reason, also renamed configura…

b8d21fb

…tion configmaps

Contributor Author

jessesimpson36 commented Apr 3, 2024

this branch is simply an investigation. I will likely take what I learned and re-implement it later. I want to keep the draft PR up for now though just for visibility.

jessesimpson36 added 2 commits

April 3, 2024 18:32


          refactor: moved common large sections to _ named template

9ccf0a1


          refactor: dedup

f9292ff

aabouzaid force-pushed the main branch from 2f86859 to 3b6ed39 Compare

April 8, 2024 21:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment