Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zeebe-grpc v8.0.4 #323

Closed
wants to merge 3 commits into from
Closed

zeebe-grpc v8.0.4 #323

wants to merge 3 commits into from

Conversation

Andy-JB
Copy link
Contributor

@Andy-JB Andy-JB commented Aug 19, 2022 •
edited

Update gRPC internals to align to Zeebe 8.0.4

Changes

  • Update zeebe-grpc to 8.0.4
  • Expose retryBackoff parameter for fail job command

API Updates

New Features (required)

The retryBackoff parameter is now available when failing a job.

Deprecations (required)

N/A

Enhancements (optional)

N/A

Checklist

  • Unit tests
  • Documentation

References

Fixes #302, #322

@Andy-JB Andy-JB marked this pull request as draft August 19, 2022 06:18
@Andy-JB Andy-JB changed the title Ft/zeebe grpc v8 zeebe-grpc v8.0.4 Aug 20, 2022
@coveralls
Copy link

coveralls commented Aug 20, 2022 •
edited

Pull Request Test Coverage Report for Build 3464959177

  • 7 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.148%
Totals Coverage Status
Change from base Build 3048422225: 0.0%
Covered Lines: 740
Relevant Lines: 786
💛 - Coveralls

@Andy-JB
Update for zeebe-grpc 8.0.4
e2ac266 
zeebe 8.0.4

fix parameters

default retryBackoff

fix test missing retry_backoff

correct naming of retryBackOff

no default backoff in fail_job

format

fix unit test

update gateway mock

update documentation for 8.0.4
@Andy-JB Andy-JB marked this pull request as ready for review August 20, 2022 08:44
@Andy-JB
Copy link
Contributor Author

Andy-JB commented Aug 20, 2022

Hi @JonatanMartens, can you please review this when you have time?

Regards,
Andy

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Andy-JB
❌ JonatanMartens
You have signed the CLA already but the status is still pending? Let us recheck it.

@SyntaxRules-avant
Copy link

ping @JonatanMartens for a review- because this upgrade contains some very useful features for me!

@dimastbk
Copy link
Collaborator

fixed in #383

@dimastbk dimastbk closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonatanMartens JonatanMartens Awaiting requested review from JonatanMartens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Andy-JB @coveralls @CLAassistant @SyntaxRules-avant @dimastbk @JonatanMartens