fix: disable emails for platform #15089
Merged
+34
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
keithwillcode
added
core
dosubot
bot
added
emails
ThyMinimalDev
previously approved these changes
May 17, 2024
Graphite Automations"Add platform team as reviewer" took an action on this PR • (05/17/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 321 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/17/2024 12:31:56pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 6cbd1c9 Started: 05/17/2024 12:27:29pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
MEETING_ENDED, MEETING_STARTED should create/remove scheduledWebhookTriggers for existing bookings
Retry 2 • Retry 1 • Initial Attempt |
5.06% (9)9 / 178 runsfailed over last 7 days |
34.27% (61)61 / 178 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Paid booking should be able to be rescheduled
Retry 1 • Initial Attempt |
3.35% (7)7 / 209 runsfailed over last 7 days |
14.83% (31)31 / 209 runsflaked over last 7 days |
|
Stripe integration Paid booking should be able to be cancelled
Retry 1 • Initial Attempt |
1.92% (4)4 / 208 runsfailed over last 7 days |
11.54% (24)24 / 208 runsflaked over last 7 days |
📄 apps/web/playwright/payment-apps.e2e.ts • 8 Flakes
Top 1 Common Error Messages
|
|
8 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Payment app Should be able to edit paypal price, currency
Retry 1 • Initial Attempt |
1.14% (3)3 / 264 runsfailed over last 7 days |
1.14% (3)3 / 264 runsflaked over last 7 days |
|
Payment app when more than one payment app is installed the price should be updated when changing settings
Retry 1 • Initial Attempt |
1.14% (3)3 / 264 runsfailed over last 7 days |
0.76% (2)2 / 264 runsflaked over last 7 days |
|
Payment app Should display App is not setup already for alby
Retry 1 • Initial Attempt |
1.14% (3)3 / 264 runsfailed over last 7 days |
1.52% (4)4 / 264 runsflaked over last 7 days |
|
Payment app Should be able to edit stripe price, currency
Retry 1 • Initial Attempt |
1.14% (3)3 / 264 runsfailed over last 7 days |
0.76% (2)2 / 264 runsflaked over last 7 days |
|
Payment app Should be able to edit alby price, currency
Retry 1 • Initial Attempt |
1.14% (3)3 / 264 runsfailed over last 7 days |
1.52% (4)4 / 264 runsflaked over last 7 days |
|
Payment app Should not display App is not setup already for non payment app
Retry 1 • Initial Attempt |
1.14% (3)3 / 264 runsfailed over last 7 days |
0.76% (2)2 / 264 runsflaked over last 7 days |
|
Payment app Should only be allowed to enable one payment app
Retry 1 • Initial Attempt |
1.14% (3)3 / 264 runsfailed over last 7 days |
1.14% (3)3 / 264 runsflaked over last 7 days |
|
Payment app Should display App is not setup already for paypal
Retry 1 • Initial Attempt |
1.14% (3)3 / 264 runsfailed over last 7 days |
0.76% (2)2 / 264 runsflaked over last 7 days |
📄 apps/web/playwright/signup.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Signup Flow Test Email verification sent if enabled
Retry 1 • Initial Attempt |
1.26% (3)3 / 239 runsfailed over last 7 days |
23.85% (57)57 / 239 runsflaked over last 7 days |
📄 apps/web/playwright/team/team-invitation.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Team Invitation (non verified)
Retry 2 • Retry 1 • Initial Attempt |
6.64% (16)16 / 241 runsfailed over last 7 days |
4.98% (12)12 / 241 runsflaked over last 7 days |
|
Team Invitation (verified)
Retry 1 • Initial Attempt |
3.32% (8)8 / 241 runsfailed over last 7 days |
7.05% (17)17 / 241 runsflaked over last 7 days |
📄 apps/web/playwright/managed-event-types.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Managed Event Types Can create managed event type
Retry 1 • Initial Attempt |
6.67% (15)15 / 225 runsfailed over last 7 days |
5.33% (12)12 / 225 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 9 Flakes
Top 1 Common Error Messages
|
|
9 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1 • Initial Attempt |
1.32% (3)3 / 228 runsfailed over last 7 days |
59.65% (136)136 / 228 runsflaked over last 7 days |
|
Popup Tests should be able to reschedule
Retry 1 • Initial Attempt |
-152.81% (-136)-136 / 89 runsfailed over last 7 days |
152.81% (136)136 / 89 runsflaked over last 7 days |
|
Popup Tests should open Routing Forms embed on click
Retry 1 • Initial Attempt |
-150.56% (-134)-134 / 89 runsfailed over last 7 days |
150.56% (134)134 / 89 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1 • Initial Attempt |
-144.94% (-129)-129 / 89 runsfailed over last 7 days |
147.19% (131)131 / 89 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1 • Initial Attempt |
-150.57% (-131)-131 / 87 runsfailed over last 7 days |
150.57% (131)131 / 87 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-150.57% (-131)-131 / 87 runsfailed over last 7 days |
150.57% (131)131 / 87 runsflaked over last 7 days |
|
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1 • Initial Attempt |
-150.57% (-131)-131 / 87 runsfailed over last 7 days |
150.57% (131)131 / 87 runsflaked over last 7 days |
|
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1 • Initial Attempt |
-150.57% (-131)-131 / 87 runsfailed over last 7 days |
150.57% (131)131 / 87 runsflaked over last 7 days |
|
Popup Tests should open on clicking child element
Retry 1 • Initial Attempt |
-148.84% (-128)-128 / 86 runsfailed over last 7 days |
148.84% (128)128 / 86 runsflaked over last 7 days |
📄 apps/web/playwright/managedBooking/advancedOptions.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Check advanced options in a managed team event type Check advanced options in a managed team event type without offer seats
Retry 1 • Initial Attempt |
0% (0)0 / 227 runsfailed over last 7 days |
47.14% (107)107 / 227 runsflaked over last 7 days |
📄 apps/web/playwright/login.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
user can login & logout succesfully -- legacy login flow user & logout using dashboard
Retry 1 • Initial Attempt |
0% (0)0 / 226 runsfailed over last 7 days |
17.26% (39)39 / 226 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes
Top 1 Common Error Messages
|
|
4 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace
Retry 1 • Initial Attempt |
0.44% (1)1 / 225 runfailed over last 7 days |
60% (135)135 / 225 runsflaked over last 7 days |
|
Namespacing Inline Embed Add inline embed using a namespace without reload
Retry 1 • Initial Attempt |
0.44% (1)1 / 225 runfailed over last 7 days |
60.44% (136)136 / 225 runsflaked over last 7 days |
|
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt |
0% (0)0 / 225 runsfailed over last 7 days |
63.56% (143)143 / 225 runsflaked over last 7 days |
|
Namespacing Different namespaces can have different init configs
Retry 1 • Initial Attempt |
0% (0)0 / 223 runsfailed over last 7 days |
60.09% (134)134 / 223 runsflaked over last 7 days |
📄 apps/web/playwright/booking-pages.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
pro user -- legacy Time slots should be reserved when selected
Retry 1 • Initial Attempt |
0% (0)0 / 219 runsfailed over last 7 days |
8.22% (18)18 / 219 runsflaked over last 7 days |
📄 packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1 • Initial Attempt |
14.85% (34)34 / 229 runsfailed over last 7 days |
35.37% (81)81 / 229 runsflaked over last 7 days |
📄 apps/web/playwright/organization/booking.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Bookings Team Event Can create a booking for Round Robin EventType
Retry 2 • Retry 1 • Initial Attempt |
8.12% (19)19 / 234 runsfailed over last 7 days |
27.78% (65)65 / 234 runsflaked over last 7 days |
📄 apps/web/playwright/booking-limits.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Duration limits day
Retry 1 • Initial Attempt |
5.17% (12)12 / 232 runsfailed over last 7 days |
0.86% (2)2 / 232 runsflaked over last 7 days |
Udit-takkar
reviewed
May 17, 2024
Comment on lines
160
to
166
| !isPlatform && | ||
| (await sendEmailVerification({ | ||
| email: orgOwnerEmail, | ||
| language: ctx.user.locale, | ||
| username: ownerProfile.username || "", | ||
| })); | ||
|
|
There was a problem hiding this comment.
NIT: we should probably move this check inside sendEmailVerification.
if (isPlatform) {
log.warn("Skipping Email verification");
return { ok: true, skipped: true };
}
There was a problem hiding this comment.
Might have to go with because e2e fails for this
There was a problem hiding this comment.
@Udit-takkar do we have tests for if email verification is skipped condition?
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
supalarry
previously approved these changes
May 17, 2024
| prevLink: null, | ||
| newLink: `${getOrgFullOrigin(slug, { protocol: true })}/${ownerProfile.username}`, | ||
| }); | ||
| !isPlatform && |
There was a problem hiding this comment.
I think that it's better to write:
if (!isPlatform) {
await sendOrganizationCreationEmail(...)
}
The && can be used in if statements themselves but this is a case for using if statement and same below.
supalarry
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a check to disable sending org creation and verification emails for a platform user.
NOTE: This is a temporary fix for the time being and won't be needed after #14911 is merged