fix: incorrect encryption string instructions #15086
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucasjohnston is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
❗️ .env changes
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
lucasjohnston
changed the title
Graphite Automations"Add community label" took an action on this PR • (05/17/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (05/17/24)1 reviewer was added to this PR based on Keith Williams's automation. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As outlined in #13290, any new calcom user following the .env example is unable to perform any administrative function as 2FA is required.
Because
"latin1"is specified as the encryption/decryption method inlib/crypto.ts, using a base64 encoded string (as is currently suggested) results in a 44 length string, which breaks the 2FA process.A cleaner solution would be to update
crypto.tsdirectly, but this was already rejected in #13484 in favour of the ongoing refactor in #12698. This PR is a temporary fix until the larger refactor has been completed.Mandatory Tasks