feat: outlook 365 calendar endpoints #15077

Ryukemeister · 2024-05-16T11:21:47Z

What does this PR do?

This PR adds the endpoints for the microsoft outlook calendar. The frontend can be done in a follow PR once the endpoints are merged. Also added some e2e tests for case where access token or origin might be invalid and also when all the credentials are good

…s and redirect url for office 365 calendar

linear · 2024-05-16T11:21:50Z

CAL-3544 Outlook/office365 Integration - Connect Atom

github-actions · 2024-05-16T11:22:01Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

socket-security · 2024-05-16T11:22:57Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

…connect-atom

vercel · 2024-05-16T11:23:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 30, 2024 4:45pm

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		May 30, 2024 4:45pm
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		May 30, 2024 4:45pm

graphite-app · 2024-05-16T11:25:11Z

Graphite Automations

"Add platform team as reviewer" took an action on this PR • (05/16/24)

1 reviewer was added to this PR based on Keith Williams's automation.

github-actions · 2024-05-16T11:34:25Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2024-05-16T11:35:58Z

Current Playwright Test Results Summary

✅ 42 Passing - ❌ 1 Failing - ⚠️ 1 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/17/2024 08:47:50pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: ddcdddb

Started: 05/17/2024 08:46:42pm UTC

❌ Failures

📄 apps/web/playwright/teams.e2e.ts • 1 Failure

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Teams - NonOrg -- future Can create a booking for Round Robin EventType Retry 2 • Retry 1 • Initial Attempt Error: expect(received).toBe(expected) // Object.is equality... `expect(received).toBe(expected) // Object.is equality Expected: true Received: false`	6.82% (18) 18 / 264 runs failed over last 7 days	25% (66) 66 / 264 runs flaked over last 7 days

⚠️ Flakes

📄 apps/web/playwright/signup.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Signup Flow Test Email verification sent if enabled Retry 1 • Initial Attempt	1.13% (3) 3 / 266 runs failed over last 7 days	24.44% (65) 65 / 266 runs flaked over last 7 days

View Detailed Build Results

…connect-atom

CLAassistant · 2024-05-30T11:14:36Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ ThyMinimalDev
✅ Ryukemeister
❌ Rajiv Sahal

Rajiv Sahal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

…connect-atom

ThyMinimalDev · 2024-05-31T10:25:45Z

packages/platform/constants/apps.ts

+export const OFFICE_365_CALENDAR_TYPE = "office365_calendar";
+export const OFFICE_365_CALENDAR_ID = "office365-calendar";
+export const GOOGLE_CALENDAR = "google";
+export const MICROSOFT_OUTLOOK_CALENDAR = "google";


ThyMinimalDev · 2024-05-31T10:37:19Z

apps/api/v2/src/ee/calendars/calendars.interface.ts

+
+export interface CalendarApp {
+  save(state: string, code: string, origin: string): Promise<{ url: string }>;
+  check(userId: number): Promise<{ status: string }>;


check(userId: number): Promise<ApiResponse>;

ThyMinimalDev · 2024-05-31T10:38:01Z

apps/api/v2/src/ee/calendars/calendars.interface.ts

+}
+
+export interface OAuthCalendarApp extends CalendarApp {
+  connect(authorization: string, req: Request): Promise<{ status: string; data: { authUrl: string } }>;


connect(authorization: string, req: Request): Promise<ApiResponse<{ authUrl: string }>>

ThyMinimalDev · 2024-05-31T10:39:07Z

apps/api/v2/src/ee/calendars/services/gcal.service.ts

+    const origin = req.get("origin") ?? req.get("host");
+    const redirectUrl = await await this.getCalendarRedirectUrl(accessToken, origin ?? "");
+
+    return { status: "SUCCESS", data: { authUrl: redirectUrl } };


{ status: SUCCESS_STATUS, data: { authUrl: redirectUrl } };

ThyMinimalDev · 2024-05-31T10:39:33Z

apps/api/v2/src/ee/calendars/services/outlook.service.ts

+    const origin = req.get("origin") ?? req.get("host");
+    const redirectUrl = await await this.getCalendarRedirectUrl(accessToken, origin ?? "");
+
+    return { status: "SUCCESS", data: { authUrl: redirectUrl } };


SUCCESS_STATUS

Ryukemeister added 10 commits May 14, 2024 11:41

init endpoints for office 365 syncing

fb907b6

get web app url for oauth

00c97d4

update typings

808a3db

nethods for office 365 calendar

a3f8e64

update office 365 connect endpoint

bda0a26

update packages

093182a

add calendar type and if office 365 calendar

af0df73

add SelectedCalendarsRepository and TokensModule

6bea3a2

add functions for getting oauth credentials, getting default calendar…

263402a

…s and redirect url for office 365 calendar

update controllers

fd2bf7c

keithwillcode added core area: core, team members only platform Anything related to our platform plan labels May 16, 2024

graphite-app bot requested a review from a team May 16, 2024 11:22

dosubot bot added api area: API, enterprise API, access token, OAuth calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar ✨ feature New feature or request labels May 16, 2024

Merge branch 'main' into rajiv/cal-3544-outlookoffice365-integration-…

14a5cb7

…connect-atom

vercel bot deployed to Preview – ai May 16, 2024 11:26 View deployment

vercel bot deployed to Preview – api May 16, 2024 11:32 View deployment

vercel bot deployed to Preview – dev May 16, 2024 11:44 View deployment

e2e tests for office 365 calendar endpoints

5ec9b0e

vercel bot deployed to Preview – api May 16, 2024 13:34 View deployment

vercel bot deployed to Preview – dev May 16, 2024 13:40 View deployment

vercel bot deployed to Preview – api May 27, 2024 05:51 View deployment

vercel bot deployed to Preview – dev May 27, 2024 06:05 View deployment

Ryukemeister added 3 commits May 29, 2024 01:54

update typings

1525016

abstract microsoft outlook into its own module

a179652

Merge branch 'main' into rajiv/cal-3544-outlookoffice365-integration-…

611f840

…connect-atom

vercel bot deployed to Preview – ai May 28, 2024 20:31 View deployment

vercel bot deployed to Preview – api May 28, 2024 20:38 View deployment

vercel bot deployed to Preview – dev May 28, 2024 20:49 View deployment

Rajiv Sahal added 6 commits May 30, 2024 15:54

add one common interface for calendar apps

1df3dee

make calendars dynamic

ddfa52f

abstract every calendar app into its own service

7deb13b

cleanup

d28333f

make all calendar endpoints dynamic

3cc149c

calendar app constants

80fc777

Rajiv Sahal and others added 3 commits May 30, 2024 16:48

cleanup

bbd9bdf

remove unused repositories

0bfb07e

Merge branch 'main' into rajiv/cal-3544-outlookoffice365-integration-…

1a62ce3

…connect-atom

vercel bot deployed to Preview – ai May 30, 2024 11:27 View deployment

vercel bot deployed to Preview – api May 30, 2024 11:33 View deployment

vercel bot deployed to Preview – dev May 30, 2024 11:38 View deployment

Merge branch 'main' into rajiv/cal-3544-outlookoffice365-integration-…

5141942

…connect-atom

vercel bot deployed to Preview – ai May 30, 2024 16:45 View deployment

vercel bot deployed to Preview – api May 30, 2024 16:49 View deployment

vercel bot deployed to Preview – dev May 30, 2024 16:54 View deployment

ThyMinimalDev reviewed May 31, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: outlook 365 calendar endpoints #15077

feat: outlook 365 calendar endpoints #15077

Ryukemeister commented May 16, 2024 •

edited

linear bot commented May 16, 2024

github-actions bot commented May 16, 2024 •

edited

socket-security bot commented May 16, 2024 •

edited

vercel bot commented May 16, 2024 •

edited

graphite-app bot commented May 16, 2024

github-actions bot commented May 16, 2024 •

edited

deploysentinel bot commented May 16, 2024 •

edited

Test Case Results

Test Case Results

CLAassistant commented May 30, 2024 •

edited

ThyMinimalDev May 31, 2024

ThyMinimalDev May 31, 2024

ThyMinimalDev May 31, 2024 •

edited

ThyMinimalDev May 31, 2024

ThyMinimalDev May 31, 2024

feat: outlook 365 calendar endpoints #15077

Are you sure you want to change the base?

feat: outlook 365 calendar endpoints #15077

Conversation

Ryukemeister commented May 16, 2024 • edited

What does this PR do?

linear bot commented May 16, 2024

github-actions bot commented May 16, 2024 • edited

socket-security bot commented May 16, 2024 • edited

vercel bot commented May 16, 2024 • edited

graphite-app bot commented May 16, 2024

Graphite Automations

github-actions bot commented May 16, 2024 • edited

📦 Next.js Bundle Analysis for @calcom/web

deploysentinel bot commented May 16, 2024 • edited

Current Playwright Test Results Summary

❌ Failures

Test Case Results

⚠️ Flakes

Test Case Results

CLAassistant commented May 30, 2024 • edited

ThyMinimalDev May 31, 2024

Choose a reason for hiding this comment

ThyMinimalDev May 31, 2024

Choose a reason for hiding this comment

ThyMinimalDev May 31, 2024 • edited

Choose a reason for hiding this comment

ThyMinimalDev May 31, 2024

Choose a reason for hiding this comment

ThyMinimalDev May 31, 2024

Choose a reason for hiding this comment

Ryukemeister commented May 16, 2024 •

edited

github-actions bot commented May 16, 2024 •

edited

socket-security bot commented May 16, 2024 •

edited

vercel bot commented May 16, 2024 •

edited

github-actions bot commented May 16, 2024 •

edited

deploysentinel bot commented May 16, 2024 •

edited

CLAassistant commented May 30, 2024 •

edited

ThyMinimalDev May 31, 2024 •

edited