feat(proto): add additional host/port and replicaset name in data source proto #11990
+1,046
−1,852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-bytebase
reviewed
May 14, 2024
d-bytebase
reviewed
May 14, 2024
Signed-off-by: h3n4l <oysterdays@gmail.com>
h3n4l
force-pushed
the
h3n4l/byt-5539-support-mongodb-cluster
branch
from
88c2ac1
to
74354ce
Compare
|
PTAL @d-bytebase @RainbowDashy |
Signed-off-by: h3n4l <oysterdays@gmail.com>
d-bytebase
approved these changes
May 15, 2024
Signed-off-by: h3n4l <oysterdays@gmail.com>
Signed-off-by: h3n4l <oysterdays@gmail.com>
Signed-off-by: h3n4l <oysterdays@gmail.com>
RainbowDashy
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDB replica set can specify multiple-host/port explicitly, one way to support this is modify our
host, portto repeated field, but requires a lots of work. So I add two new fields namedadditional_hostsandadditional_ports. Also, it is not common in RDBMS.