test java 21 #8589
Draft
test java 21 #8589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lbergelson
commented
Nov 17, 2023
lbergelson
commented
- update to gradle 8.4 and build with java 21
- fixing or supressing various warnings
- in progress
- allow warnings and update actions to 21 so we can run tetsts
|
Github actions tests reported job failures from actions build 6906804987
|
lot of warnings are active, serialization warnigns suppressed to unhide the others
* adding explicit casts or types to some numeric operations - the warning caught a potential overflow bug, although one we were very unlikely to ever hit * supressing 'this-escape' warnings in GATKTool because they are an inevitable feature of the design * making several methods in GATKPath final to avoid the same warning
lbergelson
force-pushed
the
lb_java21
branch
from
85d0679
to
1ba3ebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.