-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lazy index for fixed length windower #597
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #597 +/- ##
==========================================
+ Coverage 87.25% 87.37% +0.11%
==========================================
Files 67 67
Lines 5980 6051 +71
==========================================
+ Hits 5218 5287 +69
- Misses 762 764 +2 |
@robintibor, can you review this modification on temple university dataset? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very small comments, but lgtm
Thanks @bruAristimunha for the comments! :) |
Thank you @PierreGtch =) |
This adds the option to use lazily compute the trial bounds when using
create_fixed_length_windows
.Useful when working with small strides that can lead to metadata DataFrames nearly the same size as the dataset itself.