Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy index for fixed length windower #597

Merged
merged 19 commits into from
May 21, 2024

Conversation

PierreGtch
Copy link
Collaborator

This adds the option to use lazily compute the trial bounds when using create_fixed_length_windows.

Useful when working with small strides that can lead to metadata DataFrames nearly the same size as the dataset itself.

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 97.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.37%. Comparing base (c409800) to head (e773410).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #597      +/-   ##
==========================================
+ Coverage   87.25%   87.37%   +0.11%     
==========================================
  Files          67       67              
  Lines        5980     6051      +71     
==========================================
+ Hits         5218     5287      +69     
- Misses        762      764       +2     

@bruAristimunha
Copy link
Collaborator

@robintibor, can you review this modification on temple university dataset?

@bruAristimunha bruAristimunha marked this pull request as ready for review May 20, 2024 16:45
Copy link
Collaborator

@bruAristimunha bruAristimunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very small comments, but lgtm

braindecode/preprocessing/windowers.py Outdated Show resolved Hide resolved
braindecode/preprocessing/windowers.py Outdated Show resolved Hide resolved
braindecode/preprocessing/windowers.py Show resolved Hide resolved
braindecode/preprocessing/windowers.py Outdated Show resolved Hide resolved
braindecode/preprocessing/windowers.py Outdated Show resolved Hide resolved
braindecode/preprocessing/windowers.py Outdated Show resolved Hide resolved
braindecode/preprocessing/windowers.py Show resolved Hide resolved
@PierreGtch PierreGtch enabled auto-merge (squash) May 21, 2024 11:42
@PierreGtch
Copy link
Collaborator Author

Thanks @bruAristimunha for the comments! :)

@bruAristimunha bruAristimunha self-requested a review May 21, 2024 12:30
@PierreGtch PierreGtch merged commit 0114896 into braindecode:master May 21, 2024
20 checks passed
@bruAristimunha
Copy link
Collaborator

Thank you @PierreGtch =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants