-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add len_last_layer to USleep model as other sleep stager model #418
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a test?
…her sleep models and be able to create a test to check the accuracy of len_last_layer
…feats=True si the same than model.len_last_layer
…e the clf is not created
Codecov Report
@@ Coverage Diff @@
## master #418 +/- ##
==========================================
+ Coverage 84.17% 84.19% +0.02%
==========================================
Files 46 46
Lines 3601 3606 +5
==========================================
+ Hits 3031 3036 +5
Misses 570 570 |
kernel_size=1, | ||
stride=1, | ||
padding=0, | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tgnassou can you explain somewhere why you don't take as features the activations before the last softmax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agramfort I do it because I take thefeatures before what the author calls classifier (3 conv layers). But it is also possible to consider the features the activation before the last softmax. Do you think there is a better choice ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok then. Can you just add a comment in the code about this?
I added the attribut len_last_layer to USleep model like the other sleep stager models.
@agramfort