Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add len_last_layer to USleep model as other sleep stager model #418

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

tgnassou
Copy link
Contributor

@tgnassou tgnassou commented Oct 5, 2022

I added the attribut len_last_layer to USleep model like the other sleep stager models.

@agramfort

Copy link
Collaborator

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test?

@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #418 (d00cd81) into master (95bdab9) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head d00cd81 differs from pull request most recent head f62139b. Consider uploading reports for the commit f62139b to get more accurate results

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   84.17%   84.19%   +0.02%     
==========================================
  Files          46       46              
  Lines        3601     3606       +5     
==========================================
+ Hits         3031     3036       +5     
  Misses        570      570              

kernel_size=1,
stride=1,
padding=0,
),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgnassou can you explain somewhere why you don't take as features the activations before the last softmax?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agramfort I do it because I take thefeatures before what the author calls classifier (3 conv layers). But it is also possible to consider the features the activation before the last softmax. Do you think there is a better choice ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok then. Can you just add a comment in the code about this?

@tgnassou tgnassou changed the title [MRG] Add len_last_layer to USleep model as other sleep stager model [WIP] Add len_last_layer to USleep model as other sleep stager model Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants