-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Runtime improvements #321
Open
gemeinl
wants to merge
8
commits into
braindecode:master
Choose a base branch
from
gemeinl:speed_ups
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as soon as a discrepancy is detected and does not go trhough all the files.
…sumes a massive amount of time
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
+ Coverage 83.03% 83.10% +0.06%
==========================================
Files 55 55
Lines 3838 3853 +15
==========================================
+ Hits 3187 3202 +15
Misses 651 651 |
can you also compare to torch.save ? I think it's what most pytorch
users would expect. And the .pt extension is clear of how to load such
files.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced runtime of
TUHAbonormal
from 2 min on master to 44s.Reduced runtime of
TUH
from 58 min on master to 10 min.master:
this PR: