Add support for range selection to RangeTool
#13855
Conversation
mattpap
force-pushed
the
mattpap/13646_RangeTool_select
branch
from
557b028
to
2535273
Compare
mattpap
force-pushed
the
mattpap/13646_RangeTool_select
branch
from
2535273
to
5c8f4b6
Compare
| @@ -524,6 +524,13 @@ def __init__(self, *args, **kwargs) -> None: | |||
| A shaded annotation drawn to indicate the configured ranges. | |||
| """) | |||
|
|
|||
| select_gesture = Enum("pan", "tap", "none", default="none", help=""" | |||
There was a problem hiding this comment.
Is there another word we can use here besides "select"? Concerned about overloading this term and confusion with data selections. start_gesture maybe?
There was a problem hiding this comment.
I think this question boils down to what RangeTool actually is, because when I see this name, I ask RangeWhat?Tool and the answer is always RangeSelectTool (or RangeSelectionTool), thus everything in this PR (branch name, PR title, new properties, docstrings, etc.) involve the word select. I thought about alternatives, but nothing comes close in meaning.
start_gesturemaybe?
To me this is the same as above, start_of_what?_gesture. Maybe let's go generic and simply say interaction_gesture? Or perhaps we could be specific with range_selection_gesture and introduce "range selection" as a well defined term (in a glossary of terms) to make sure that we differentiate different types of selections. To me this is a situation similar to what we have with the term "layout", which on its own is really context dependent and may mean server things: CSS/DOM layout, (our) computed layout (LayoutDOM and canvas layouts) and perhaps other.
| if (!this.model.active) { | ||
| return | ||
| } | ||
|
|
||
| if (ev.key == "Escape") { | ||
| if (this._is_selecting) { | ||
| this._stop() | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
This seems like it could be a bit more compact
| if (!this.model.active) { | |
| return | |
| } | |
| if (ev.key == "Escape") { | |
| if (this._is_selecting) { | |
| this._stop() | |
| return | |
| } | |
| } | |
| if (this.model.active) { | |
| if (ev.key == "Escape" && this._is_selecting) { | |
| this._stop() | |
| } | |
| } |
This optionally allows users of
RangeToolto make range selection gesture, typically withpangesture. This PR additionally experiments with making this configurable, allowing eitherpanortap(tap,move,tap) gestures, to avoid conflict with other tools.Example of using
pangesture to make range selection:Screencast.from.30.04.2024.13.09.49.webm
fixes #13646