-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for modifiers and allow to auto-activate WheelZoomTool
#13815
Conversation
Cool! Can you describe the details of how it "redesigns how tool event handlers are invoked"? |
The previous approach using signals didn't allow for returning a value from handlers (like |
f20a3f7
to
d5ccbf9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.5 #13815 +/- ##
==============================================
+ Coverage 91.57% 92.64% +1.06%
==============================================
Files 326 326
Lines 20737 20751 +14
==============================================
+ Hits 18990 19224 +234
+ Misses 1747 1527 -220 |
Originally I started working on scroll support in
BoxAnnotation
per issue #13646, but I realized that I need to resolve the more generic issue of conditional handling of scroll events first, so that bokehjs doesn't interfere by with page scrolling, while allowing some way of easy access to scrolling functionality (like wheel zoom or wheel pan tools provide).Thus this PR:
modifiers
toWheelZoomTool
andWheelPanTool
Toolbar
for auto-activation of such tools whenmodifiers
are setThis example shows
WheelZoomTool
configured withmodifiers = dict(ctrl=True)
, first being scrolled without the modifier and then with:Screencast.from.09.04.2024.02.22.41.webm
fixes #10439