Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robustify and simplify View.has_finished() logic #13801

Open
wants to merge 2 commits into
base: branch-3.5
Choose a base branch
from

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Apr 4, 2024

The goals of this PR are:

  • use View.children() in View.has_finished() instead of overriding has_finished() in subclasses
  • make sure that all views participate in has_finished() and are marked as finished at some point in their life-cycle
  • reduce the number of exceptions to ground rules of View.has_finished()

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.65%. Comparing base (e61219b) to head (1c53845).
Report is 29 commits behind head on branch-3.5.

❗ Current head 1c53845 differs from pull request most recent head e3e1ba6. Consider uploading reports for the commit e3e1ba6 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           branch-3.5   #13801      +/-   ##
==============================================
+ Coverage       91.57%   92.65%   +1.07%     
==============================================
  Files             326      326              
  Lines           20737    20734       -3     
==============================================
+ Hits            18990    19211     +221     
+ Misses           1747     1523     -224     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant