Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for outline shapes to Text-like glyphs #13620

Merged
merged 10 commits into from May 14, 2024

Conversation

mattpap
Copy link
Contributor

@mattpap mattpap commented Dec 24, 2023

This PR adds support other outline shapes than box/rectangle to Text-like glyphs. Shapes are circumscribed onto the bounding box of text boxes, so that all content fit inside those shapes.

Example (various shapes with Text and TeX glyphs):
image

fixes #8289

@mattpap mattpap added status: WIP grant: SDG 2023 Funded from NumFOCUS Small Development Grant 2023 labels Dec 24, 2023
@mattpap mattpap added this to the 3.4 milestone Dec 24, 2023
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.51%. Comparing base (e61219b) to head (83075b3).
Report is 36 commits behind head on branch-3.5.

❗ Current head 83075b3 differs from pull request most recent head 1aa1529. Consider uploading reports for the commit 1aa1529 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           branch-3.5   #13620      +/-   ##
==============================================
+ Coverage       91.57%   92.51%   +0.93%     
==============================================
  Files             326      323       -3     
  Lines           20737    20495     -242     
==============================================
- Hits            18990    18960      -30     
+ Misses           1747     1535     -212     

@ianthomas23
Copy link
Member

This is really nice 😍

@kasra1386
Copy link

this is very good project

@mattpap mattpap modified the milestones: 3.4, 3.5 Feb 28, 2024
@mattpap mattpap changed the base branch from branch-3.4 to branch-3.5 March 14, 2024 16:51
@mattpap
Copy link
Contributor Author

mattpap commented May 12, 2024

This is tentatively ready. One big missing part of this PR is accurate hit testing, but I think this could be done separately.

bokehjs/src/lib/core/enums.ts Outdated Show resolved Hide resolved
src/bokeh/models/glyphs.py Outdated Show resolved Hide resolved
@mattpap mattpap merged commit 00c0ade into branch-3.5 May 14, 2024
25 checks passed
@mattpap mattpap deleted the mattpap/8289_text_nodes branch May 14, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grant: SDG 2023 Funded from NumFOCUS Small Development Grant 2023 status: accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Permanent labels on Networkx graph
4 participants