New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for outline shapes to Text
-like glyphs
#13620
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.5 #13620 +/- ##
==============================================
+ Coverage 91.57% 92.51% +0.93%
==============================================
Files 326 323 -3
Lines 20737 20495 -242
==============================================
- Hits 18990 18960 -30
+ Misses 1747 1535 -212 |
This is really nice 😍 |
this is very good project |
83075b3
to
6551749
Compare
This is tentatively ready. One big missing part of this PR is accurate hit testing, but I think this could be done separately. |
fc6afbe
to
1aa1529
Compare
This PR adds support other outline shapes than box/rectangle to
Text
-like glyphs. Shapes are circumscribed onto the bounding box of text boxes, so that all content fit inside those shapes.Example (various shapes with
Text
andTeX
glyphs):fixes #8289