-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements Individual Tool Visibility in Toolbar #13593
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.4 #13593 +/- ##
===========================================
Coverage 92.58% 92.58%
===========================================
Files 325 325
Lines 20728 20729 +1
===========================================
+ Hits 19191 19192 +1
Misses 1537 1537 |
I need to think about this approach in the context of other ongoing work (e.g. PR #13571), i.e. whether it makes sense for tools to be visible or whether it's their UI representation that should carry this setting. |
I did a little clean up of this PR, deprecated |
@zoeangell, thanks. |
Added the ability to set a tool's visibility in the toolbar. This was done by adding the visible property to the Python Tool Class and Tool module in bokehjs. We modeled the functionality and implementation of this feature after the toggleable property for InspectTools (e.g. CrosshairTool and HoverTool).
Setting
visible=False
for a tool will make it not show up in the toolbar, but it will still have its functionality.To test our feature we wrote Javascript unit tests and integration tests.
Graph with
box_edit = BoxEditTool(visible = True)
Graph with
box_edit = BoxEditTool(visible = False)
Resolves #8153