Optimize code paths involving data array indices #13562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattpap
added
status: WIP
type: task
tag: performance
grant: CZI R5
|
It would be great to see a before/after benchmark example |
mattpap
force-pushed
the
mattpap/perf_optimizations
branch
from
eb100b8
to
5ca5d3c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-3.4 #13562 +/- ##
===========================================
Coverage 92.59% 92.59%
===========================================
Files 325 325
Lines 20729 20729
===========================================
Hits 19194 19194
Misses 1535 1535 |
mattpap
force-pushed
the
mattpap/perf_optimizations
branch
from
5ca5d3c
to
be275f6
Compare
mattpap
force-pushed
the
mattpap/perf_optimizations
branch
from
be275f6
to
463ddf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very early work in progress. The goal of this PR is to optimize handling of data indices.