Add support for deferred loading of bokehjs' bundles #13547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## branch-3.4 #13547 +/- ##
==============================================
- Coverage 92.58% 92.58% -0.01%
==============================================
Files 325 325
Lines 20729 20748 +19
==============================================
+ Hits 19192 19209 +17
- Misses 1537 1539 +2 |
mattpap
force-pushed
the
mattpap/10166_deferred_bundles
branch
2 times, most recently
from
387dd5d
to
4d6f490
Compare
|
Will this intersect with browser caching of CDN loads? |
This uses
(this requires "Disable cache (while DevTools is open)" to be unchecked while verifying this). |
mattpap
force-pushed
the
mattpap/10166_deferred_bundles
branch
from
4d6f490
to
a3beb7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experiment in adding support for deferred bundles. Bundles are resolved the same as previously, but instead of including them via resource management, they are included either by name or respective URL in document's serialized representation and resolved by bokehjs when needed. This work for both standalone and server embedding. Additional bundles can be requested with subsequent document patches.
In the example below we can see that only
bokeh.jswas loaded with the initial HTML page, but we can use widgets and math text:Tentatively including in 3.4 milestone, but it may take some time before this is fully incorporated into bokeh's embed.