Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance datetimetick formatting #13455

Conversation

muendlein
Copy link
Contributor

All pull requests must have an associated issue in the issue tracker. If there
isn't one, please go open an issue describing the defect, deficiency or desired
feature. You can read more about our issue and PR processes in the
wiki.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #13455 (8614fcd) into branch-3.4 (b0a59ca) will decrease coverage by 0.02%.
Report is 1 commits behind head on branch-3.4.
The diff coverage is 85.71%.

@@              Coverage Diff               @@
##           branch-3.4   #13455      +/-   ##
==============================================
- Coverage       92.67%   92.65%   -0.02%     
==============================================
  Files             320      320              
  Lines           20361    20367       +6     
==============================================
+ Hits            18869    18871       +2     
- Misses           1492     1496       +4     

@bryevdv
Copy link
Member

bryevdv commented Oct 17, 2023

@muendlein There seems to be three things in this PR:

  • hiding repeats
  • scaling up on boundaries
  • adding default contexts

is that accurate? If so, I would suggest splitting this into 3 chunks of work. The first two seem fairly straightforward, but the third may require some thought so it will be easier to evaluate and iterate on isolation.

@muendlein
Copy link
Contributor Author

@bryevdv Yes that's accurate, should I provide three separate pull requests for each chunk?

@bryevdv
Copy link
Member

bryevdv commented Oct 17, 2023

@muendlein I think that would ideal I think we can speed through things more quickly with smaller individual PRs

@muendlein
Copy link
Contributor Author

Closing this PR as it will be split up into separate ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] datetime formatting: enhance default formatting
3 participants