Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery examples loading all bundles #10166

Open
bryevdv opened this issue Jun 13, 2020 · 3 comments · Fixed by #10292 · May be fixed by #13547
Open

Gallery examples loading all bundles #10166

bryevdv opened this issue Jun 13, 2020 · 3 comments · Fixed by #10292 · May be fixed by #13547

Comments

@bryevdv
Copy link
Member

bryevdv commented Jun 13, 2020

The gallery examples are not pruning the bundles down to the minimum necessary:

Screen Shot 2020-06-13 at 4 34 45 PM

@bryevdv
Copy link
Member Author

bryevdv commented Jul 4, 2020

OK the proximate cause is because None is passed here:

bundle = bundle_for_objs_and_resources(None, resources)

Need to determine it that is for a reason or just an accident.

@bryevdv
Copy link
Member Author

bryevdv commented Jul 4, 2020

passing models instead of None solves the immediate issue here. @mattpap this was last changed in #9198 is there any reason not to pass models here?

Edit: noting there are specific tests to check that all 4 bundles are included, but definitely not clear why that should be necessary.

@bryevdv bryevdv removed this from the 2.2 milestone Aug 7, 2020
@bryevdv bryevdv reopened this Aug 7, 2020
@bryevdv
Copy link
Member Author

bryevdv commented Aug 7, 2020

This will require more thought, the current autoload script is not smart enough to load additional bundles in case a second autoload needs more/differet bundles than a first autoload on a page. This does not affect the gallery pages that have only a single embed, but does affect other pages that have many embeds.

@mattpap mattpap linked a pull request Nov 24, 2023 that will close this issue
1 task
@mattpap mattpap added this to the 3.4 milestone Nov 24, 2023
@mattpap mattpap modified the milestones: 3.4, 3.5 Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants