Add a regression test for issue #13787

bokeh · May 2, 2024 · be35df7 · be35df7
1 parent 142f84c
commit be35df7
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 0 deletions.
diff --git a/...baselines/linux/Bug__in_issue_#13787__doesn't_allow_to_render_a_DataTable_in_a_Dialog.blf b/...baselines/linux/Bug__in_issue_#13787__doesn't_allow_to_render_a_DataTable_in_a_Dialog.blf
@@ -0,0 +1,3 @@
+Dialog bbox=[0, 0, 400, 200]
+  bokeh.models.dom.Text
+  DataTable bbox=[6, 33, 388, 160]
diff --git a/...linux/Bug__in_issue_#13787__doesn't_allow_to_render_a_DataTable_in_a_Dialog.png b/...linux/Bug__in_issue_#13787__doesn't_allow_to_render_a_DataTable_in_a_Dialog.png
diff --git a/bokehjs/test/integration/regressions.ts b/bokehjs/test/integration/regressions.ts
@@ -29,6 +29,7 @@ import {
   GridPlot,
   Tooltip,
   Node, Indexed,
+  Dialog,
 } from "@bokehjs/models"
 
 import {
@@ -3917,4 +3918,38 @@ describe("Bug", () => {
       await display(plot)
     })
   })
+
+  describe("in issue #13787", () => {
+    it("doesn't allow to render a DataTable in a Dialog", async () => {
+      const source = new ColumnDataSource({
+        data: {
+          col1: ["a", "b", "c", "d"],
+          col2: [1, 2, 3, 4],
+          col3: [10, 20, 30, 40],
+        },
+      })
+
+      const columns = [
+        new TableColumn({field: "col1", title: "col1"}),
+        new TableColumn({field: "col2", title: "col2"}),
+        new TableColumn({field: "col3", title: "col3"}),
+      ]
+      const data_table = new DataTable({source, columns, sizing_mode: "stretch_both"})
+
+      const dialog = new Dialog({
+        title: "Dialog with a data table",
+        content: data_table,
+        stylesheets: [`
+        :host {
+          position: relative; /* the default is fixed */
+          left: 10px;
+          top: 10px;
+          width: 400px;
+          height: 200px;
+        }
+        `],
+      })
+      await display(dialog, [450, 250])
+    })
+  })
 })