Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aliases #87

Open
bluzi opened this issue Oct 24, 2017 · 8 comments
Open

Add aliases #87

bluzi opened this issue Oct 24, 2017 · 8 comments

Comments

@bluzi
Copy link
Owner

bluzi commented Oct 24, 2017

Add aliases to existing names, as described in the structure

For example:
RIchard => Dick

You can also:

@Kardelio
Copy link
Contributor

Can we add aliases to a few in our pull requests (for example 3 or 4) or does an accurate pull request require all possible names to have aliases?

@Kardelio
Copy link
Contributor

Also FYI on it, just starting a few for now 😄

@bluzi
Copy link
Owner Author

bluzi commented Oct 24, 2017

Hi @Kardelio, add as many as you can :) It's a work in progress
Of course you can also add more names or translate other names to your language.

@Kardelio
Copy link
Contributor

Ok cool ill see what else I can add 😃

This was referenced Oct 24, 2017
@superpower1
Copy link
Contributor

Just wondering what I can do with a name that have multiple possible translation like Chinese and Janpanese? (Because different character may have the same spelling in English)

@bluzi
Copy link
Owner Author

bluzi commented Oct 25, 2017

Hey @superpower1, great question!

Aliases should always be in English. If you want to translate an alias, you should create a new name file, and write the alias in English.

For example:

john.json:

{
    "name": "john",
    "aliases": [
        "yoni"   
    ],
    "translations": [
        ...
    ]
}

yoni.json

{
    "name": "yoni",
    "aliases": [
        "john"   
    ],
    "translations": [
        ...
    ]
}

@roastchicken
Copy link
Collaborator

Are nicknames distinct from aliases? Are there any plans to add nicknames to this repository?

@bluzi
Copy link
Owner Author

bluzi commented Nov 1, 2017

Hey @roastchicken, feel free to add nicknames as aliases, as long as you're talking about commonly used nicknames.
After you add an alias, you may also create a name file for this alias and translate it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants