Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking for collaborators #222

Open
bluzi opened this issue Oct 28, 2017 · 11 comments
Open

Looking for collaborators #222

bluzi opened this issue Oct 28, 2017 · 11 comments

Comments

@bluzi
Copy link
Owner

bluzi commented Oct 28, 2017

We're looking for people who would like to review and approve changes to the collection.
If you're interested and you already contributed to this repository before, you may apply by submitting a comment to this issue.

The goal is to grow and to make this repository as responsive to pull requests as possible.

@haloboy777
Copy link
Contributor

I'd love to help.. 👍

@arminkhoshbin
Copy link
Collaborator

I'd be happy to help as well @bluzi

@CodeWritingCow
Copy link
Collaborator

I'd love to help too @bluzi

@roastchicken
Copy link
Collaborator

Although I just stumbled upon this and made my first PR about a minute ago, it seems interesting and I'd like to help get through the PR backlog.

@bluzi
Copy link
Owner Author

bluzi commented Nov 1, 2017

@haloboy777 @arminkhoshbin @CodeWritingCow @roastchicken

Welcome aboard!
Please click here and accept the invitation.

As you all can see, the project is getting more and more popular every day. People contributed about 400 PRs in less than a week, so feel free to merge name additions and translations, just make sure that the tests pass successfully, and that the changes make sense.

Please be nice to contributors, and create "thank you comments" after merging a PR.
I also like to help people fix their PRs when the test fails, by providing a guiding comment. Some of our contributors are not IT guys, so they may struggle with JSON and things like that.

Another important thing: Please reference every PR you merge to one or more of the following issues:

That's about it. If you need anything, if you're not sure about a PR, or if you have any question or suggestion, feel free to @mention me or contact me via email: eliran013 AT gmail.com (replace the AT with @ of course), via Hangouts, or using the issue system in this repository.

Hopefully we all make some productive things together in the near future!

@roastchicken
Copy link
Collaborator

I'm assuming we shouldn't merge our own changes, just so another pair of eyes verifies any code. Let me know if you think otherwise @bluzi, or if anyone else has an opinion on this.

@bluzi
Copy link
Owner Author

bluzi commented Nov 3, 2017

@roastchicken
Yup, sounds reasonable.

@chrisf
Copy link
Collaborator

chrisf commented Nov 4, 2017

If you're still looking, I'd be happy to help

@bluzi
Copy link
Owner Author

bluzi commented Nov 4, 2017

Sure @chrisf, we could use some more help.
Welcome aboard!

Click here to accept the invitation

@bluzi
Copy link
Owner Author

bluzi commented Nov 8, 2017

@roastchicken @ChaosKaoz @arminkhoshbin @CodeWritingCow

There are some PRs with forever-pending Travis builds.
To solve this, please edit one of the files in the PR, and make a slight change (add space at the end or something), and commit your changes.

That should kick Travis and restart the build process.

Sorry for the inconvenience, it's a Travis bug.

@jonafrank
Copy link

If you want I can help to review, also contribute in the API. The project is interesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants