Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7-Zip.Compression #722

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Tobias-B-Besemer
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Dec 1, 2019

Coverage Status

Coverage remained the same at 61.952% when pulling b7d8bb7 on Tobias-B-Besemer:7-Zip.Compression into db6c094 on bleachbit:master.

@az0
Copy link
Member

az0 commented Dec 1, 2019

Build 3.0.1.1438 (with this change)
BleachBit-3.0.1.1438-portable.zip: 12,748,059 bytes

Build 3.0.1.1430 (recent build without this change)
BleachBit-3.0.1.1430-portable.zip: 12,681,476 bytes

So the change increased the size

@Tobias-B-Besemer
Copy link
Contributor Author

Tobias-B-Besemer commented Dec 2, 2019

I saw this, too! But I needed a break! ;)
At least we can now fine tune the portable.zip separate from the library.zip! ;)

@Tobias-B-Besemer
Copy link
Contributor Author

Short explanation to the size (later more to it): Seems the compression method PPMd saves a lot of space with small files (library.zip), but waste a lot by big archives (portable.zip)... I need to do some new tests/comparison and play with the parameters of 7-Zip... ;)

@az0
Copy link
Member

az0 commented Dec 2, 2019

While it's possible to do a bit better, I expect there's little margin to improve the portable archive because most of its contents (e.g., executables, images, and the library.zip archive) are already compressed.

@Tobias-B-Besemer
Copy link
Contributor Author

Yes, but if I look at your past work, it looks like you are a perfectionist... I be one, too! And sometimes I like a bit modding and tweaking... ;) ...so why not try to find out, whats really the perfect parameters for this archives? ;)

@Tobias-B-Besemer
Copy link
Contributor Author

Btw.: I tested some of my different library.zip test files with the portable version... And yes, it's true, the portable version doesn't work with a e.g. with Deflate64 compressed archive!
As we both chated about this and tested it, we made a big mistake! We just had a look on the archives that they can be opened with the build in Win10 unzip method!
But py2exe doesn't use the build in unzip methode of Win10, it have it's own decompression algorithm! And it seems, that this algorithm is only able to decompress Deflate compressed archives!

What I have now done (and it's easy to see in the PR, because I needed to change just some lines for it) is the following:
Till now the compression parameters got defind by the variable "SZ_OPTS" one time for both archives. I copied now the variable to SZ_OPTS_LIB for the library who can only use Deflate and to SZ_OPTS_APP for the pirtable app. After changing which cariable is used in which case, we are now able to set the parameter for each archive, even if library.zip is still present. :)

And btw.: I guess I found the reason why the EXE headers of the NSIS installers don't get compressed, ATM. The path to the packer seems to be incomplete! But this must/should be changed in the NSI file and the PRs of this file should get merged serial and I have already 3 PRs open for it, so I decided, to don't write one for it, yet.

@az0
Copy link
Member

az0 commented Dec 7, 2019

I'm closing this because the current PR makes the files bigger. If you want to try again later, that's fine

@az0 az0 closed this Dec 7, 2019
@Tobias-B-Besemer
Copy link
Contributor Author

Andrew, I wasn't just finished, yet... :-/

@az0 az0 reopened this Dec 8, 2019
@az0
Copy link
Member

az0 commented Dec 8, 2019

Reopened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants