Fix 1626 - initial implementation, feedback needed. #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to show this initial implementation and collect feedback. The main question is about the warnings. For now I accumulate them per cleaner / section and show the accumulated ones, one by one. For example if there are two or more messages for given section (e.g. Firefox) only one is displayed, and so on for the rest of the sections. I have another suggestion. We can re-name the button to 'Force select all' and show a single message that describes what are the caveats in principle. Or we can have a setting in the preference dialog which toggles warnings on 'Select all'. Initial suggestion "An improvement would be to show all the warnings simultaneously. There are check boxes for each option with all options enabled by default." is very good but still I am not sure that additional set of checkboxes in the warning dialog would be effective enough.