migrate where possible from external mock package to stdlib unittest.mock #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eli-schwartz
force-pushed
the
stdlib-mock
branch
2 times, most recently
from
3253128
to
68e454f
Compare
eli-schwartz
changed the title
…mock It was moved to the stdlib in python 3.3, and the PyPI version is a backport for python versions less than 3.3. A couple of features from newer python versions that are greater than the minimum supported version are used. Add if/else guards to utilize the backport on older versions of python: - assert_called_once was introduced in python 3.6 - Unstarted patchers were introduced in python 3.8
eli-schwartz
force-pushed
the
stdlib-mock
branch
from
68e454f
to
d6bbcdd
Compare
|
Got CI to pass by conditionalizing the use of the stdlib based on python >=3.8. EDIT: the tests pass but travis hangs while "waiting for the job to finish" and exceed the max time... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was moved to the stdlib in python 3.3, and the PyPI version is a backport for python versions less than 3.3.
A couple of features from newer python versions that are greater than the minimum supported version are used. Add if/else guards to utilize the backport on older versions of python: