Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEEEP][AC-2497] Create unit test for the SubscriptionUpdate classes #4054

Merged

Conversation

cyprain-okeke
Copy link
Contributor

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Create unit test for the SubscriptionUpdate StorageSubscriptionUpdateTests,SmSeatSubscriptionUpdateTests,ServiceAccountSubscriptionUpdateTests and SeatSubscriptionUpdateTests classes.

Code changes

  • file.ext: Description of what was changed and why

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
…st.cs

Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
Signed-off-by: Cy Okeke <cokeke@bitwarden.com>
@cyprain-okeke cyprain-okeke requested a review from a team May 6, 2024 08:51
Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.01%. Comparing base (6a8d97a) to head (300f3a3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4054      +/-   ##
==========================================
+ Coverage   38.79%   39.01%   +0.21%     
==========================================
  Files        1216     1216              
  Lines       59169    59169              
  Branches     5646     5646              
==========================================
+ Hits        22955    23085     +130     
+ Misses      35157    35019     -138     
- Partials     1057     1065       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 6, 2024

Logo
Checkmarx One – Scan Summary & Details3c613bbb-e82b-4525-99c3-82c2f1f44069

No New Or Fixed Issues Found

@cyprain-okeke cyprain-okeke merged commit f94ddb2 into main May 13, 2024
49 checks passed
@cyprain-okeke cyprain-okeke deleted the ac-2497-create-unit-test-for-the-subscriptionupdate-classes branch May 13, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants