-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AC-2480] Hiding teams starter option #4044
[AC-2480] Hiding teams starter option #4044
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4044 +/- ##
=======================================
Coverage ? 38.40%
=======================================
Files ? 1209
Lines ? 58674
Branches ? 5587
=======================================
Hits ? 22532
Misses ? 35098
Partials ? 1044 ☔ View full report in Codecov by Sentry. |
New Issues
Fixed Issues
|
@@ -70,9 +70,10 @@ | |||
@{ | |||
var planTypes = Enum.GetValues<PlanType>() | |||
.Where(p => | |||
Model.Provider == null || | |||
(Model.Provider != null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed redundant Model.Provider != null
since it's always not null
if it reaches this side of the ||
.
(Model.Provider == null || | ||
p is >= PlanType.TeamsMonthly2019 and <= PlanType.EnterpriseAnnually2019 or | ||
>= PlanType.TeamsMonthly2020 and <= PlanType.EnterpriseAnnually) && | ||
p != PlanType.TeamsStarter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this extra conditional, p != PlanType.TeamsStarter
, to hide that plan
@@ -28,6 +28,8 @@ public TeamsStarterPlan() | |||
|
|||
PasswordManager = new TeamsStarterPasswordManagerFeatures(); | |||
SecretsManager = new TeamsStarterSecretsManagerFeatures(); | |||
|
|||
LegacyYear = 2024; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hides the plan on the frontend here
Type of change
Objective
Product is discontinuing the "Teams Starter" plan, and as such, we're removing it from the app. Current teams starter organizations are unaffected, which is why the plan is archived instead of outright deleted.
"Teams Starter 2023" is already archived, so you won't see any changes for it.
Client side PR: bitwarden/clients#9017
Code changes
LegacyYear
value to hide this planBefore you submit
dotnet format --verify-no-changes
) (required)