[AC-2513] Scaling PM seat count with SM seat count #4040
Merged
+731
−594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to reduce boilerplate
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4040 +/- ##
=======================================
Coverage ? 38.39%
=======================================
Files ? 1210
Lines ? 58676
Branches ? 5589
=======================================
Hits ? 22531
Misses ? 35102
Partials ? 1043 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
r-tome
previously approved these changes
May 2, 2024
r-tome
approved these changes
May 2, 2024
amorask-bitwarden
approved these changes
May 2, 2024
cturnbull-bitwarden
deleted the
billing/AC-2513/scale-pm-with-sm-seat-updates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
For organizations who have signed up for the Secrets Manager free trial via https://vault.bitwarden.com/#/register?org=teams&layout=secretsManager, this PR scales the organization's Password Manager seat count in step with adjustments to the organization's Secrets Manager seat count. We know when an organization has signed up to trial secrets manager because we're already applying a discount to the Password Manager subscription item. By checking for that discount, we can decide if we should scale Password Manager seats along with Secrets Manager.
This is due to a couple of factors:
We'll be splitting Secrets Manager to be a standalone product later this year, such that a user won't have to sign up for Password Manager in order to sign up for Secrets Manager. Until we do that, we need to do some goofy things like this to simulate that they're currently different products.
In addition, I've separated out endpoints from the Admin Console OrganizationsController.cs that are billing related into a new Billing owned OrganizationsController (same routes). As a result, the diff will be hard to read. I recommend first looking at the commit history, as I've committed in logical steps to the above description. The first commit shows the business change as requested by product, the subsequent commits are the codeowner changes. Feel free to comment on any of it.
Client-side PR: bitwarden/clients#9011
Code changes
GetBillingendpoint to this controller since it matches the base routeGET {id}/billing-status. Added new business logic toPOST {id}/sm-subscriptionthat scales PM seat counts with SM seat changes for SM standalone organizationsRecording.2024-05-02.091734.mp4
Before you submit
dotnet format --verify-no-changes) (required)