New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Context information in config response #3916
base: main
Are you sure you want to change the base?
Conversation
Useful for debugging
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3916 +/- ##
==========================================
- Coverage 36.36% 36.21% -0.16%
==========================================
Files 1158 1159 +1
Lines 56106 56134 +28
Branches 5385 5387 +2
==========================================
- Hits 20405 20330 -75
- Misses 34755 34859 +104
+ Partials 946 945 -1 ☔ View full report in Codecov by Sentry. |
@@ -1,5 +1,11 @@ | |||
namespace Bit.Core.Services; | |||
|
|||
public struct FeatureFlagContext |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎨 I am still hung up on this being associated to feature flags. My opinion is that context is a platform-level concept and should be there and not in these classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good thought, I was thinking of context in terms of the LD context, but that's entirely derived from CurrentContext
. A safe report of that context should fully describe anything that any given Feature Flag provider could use to key off of
Type of change
Objective
Adds feature flag context to config response. This is useful for debugging purposes.
Question: Is there a reason to consider this sensitive? It uses the same bearer token to, say, retrieve full sync data, so all information is retrievable through other endpoints.
Before you submit
dotnet format --verify-no-changes
) (required)