[PM-7004] Org Admin Initiate Delete #3905
Open
+334
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -579,6 +579,18 @@ | |||
| } | |||
| } | |||
|
|
|||
| [HttpPost("delete-recover-token")] | |||
| [AllowAnonymous] | |||
| public async Task PostDeleteRecoverToken([FromBody] OrganizationVerifyDeleteRecoverRequestModel model) | |||
Check warning
Code scanning / Checkmarx One
Log Forging
| @@ -579,6 +579,18 @@ | |||
| } | |||
| } | |||
|
|
|||
| [HttpPost("delete-recover-token")] | |||
| [AllowAnonymous] | |||
| public async Task PostDeleteRecoverToken([FromBody] OrganizationVerifyDeleteRecoverRequestModel model) | |||
Check warning
Code scanning / Checkmarx One
Log Forging
| </tr> | ||
| <tr style="margin: 0; box-sizing: border-box; color: #333; line-height: 25px; -webkit-font-smoothing: antialiased; -webkit-text-size-adjust: none;"> | ||
| <td class="content-block" style="font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; box-sizing: border-box; font-size: 16px; color: #333; line-height: 25px; margin: 0; -webkit-font-smoothing: antialiased; padding: 0 0 10px; -webkit-text-size-adjust: none; text-align: center;" valign="top" align="center"> | ||
| <a href="{{{Url}}}" clicktracking=off target="_blank" style="color: #ffffff; text-decoration: none; text-align: center; cursor: pointer; display: inline-block; border-radius: 5px; background-color: #175DDC; border-color: #175DDC; border-style: solid; border-width: 10px 20px; margin: 0; font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif; box-sizing: border-box; font-size: 16px; line-height: 25px; -webkit-font-smoothing: antialiased; -webkit-text-size-adjust: none;"> |
Check warning
Code scanning / Checkmarx One
Unsafe Use Of Target blank Medium
| @@ -579,6 +579,18 @@ | |||
| } | |||
| } | |||
|
|
|||
| [HttpPost("delete-recover-token")] | |||
| [AllowAnonymous] | |||
| public async Task PostDeleteRecoverToken([FromBody] OrganizationVerifyDeleteRecoverRequestModel model) | |||
Check warning
Code scanning / Checkmarx One
Log Forging
kspearrin
changed the title
eliykat
reviewed
Mar 25, 2024
There was a problem hiding this comment.
I'll leave the general review to @vincentsalucci , just wanted to throw in my 2 cents on OrganizationService.
r-tome
requested changes
Mar 27, 2024
There was a problem hiding this comment.
The implementation looks good to me but there are some changes needed including feedback from the Product team.
Ideally the OrganizationService methods should be on a new command, along with unit tests. However, if time constraints exist, this can be addressed at a later stage.
src/Core/AdminConsole/Services/Implementations/OrganizationService.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Rui Tomé <108268980+r-tome@users.noreply.github.com>
Co-authored-by: Rui Tomé <108268980+r-tome@users.noreply.github.com>
|
New Issues
Fixed Issues
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: Rui Tomé <108268980+r-tome@users.noreply.github.com>
Where can I find examples of using commands? |
r-tome
requested changes
Apr 1, 2024
Co-authored-by: Rui Tomé <108268980+r-tome@users.noreply.github.com>
r-tome
requested changes
Apr 8, 2024
r-tome
previously approved these changes
Apr 9, 2024
jlf0dev
reviewed
Apr 23, 2024
There was a problem hiding this comment.
Does this belong in Auth? Feels like it might be more Admin Console
There was a problem hiding this comment.
You're right, the clients code was already moved to AC ownership so I also moved this.
# Conflicts: # src/Core/Services/IMailService.cs # src/Core/Services/NoopImplementations/NoopMailService.cs
…uest acceptance endpoint
… organization, string token) method
eliykat
reviewed
Apr 25, 2024
|
|
||
| Click the link below to complete the deletion of your organization. | ||
|
|
||
| If you did not request this email to delete your Bitwarden organization, you can safely ignore it. |
There was a problem hiding this comment.
Maybe a nit, but if you didn't request this email you should probably be worried! Someone is trying to delete your organization. Maybe "If you did not request this email to delete your Bitwarden organization, please contact us." ?
There was a problem hiding this comment.
Good point. I am not opposed to changing that.
eliykat
previously approved these changes
Apr 25, 2024
…handle exceptions
vincentsalucci
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
This PR adds support for support to initiate a delete of an organization that is then confirmed by the org admin via email.
Code changes
TODO
Before you submit
dotnet format --verify-no-changes) (required)